Only enforce the 'chromium' check in MB for the default config file.

Only enforce the 'chromium' check in MB for the default config file.

r380254 introduced a bug where we would complain if *any* MB config
file did not have a 'chromium' master defined. We only want to
enforce that check in the Chromium repo.

This CL fixes that issue, and reworks the MB implementation a bit
so that we are handling return codes a bit more consistently.

R=dalecurtis@chromium.org, kjellander@chromium.org, jbudorick@chromium.org
BUG=

Committed: https://crrev.com/255085eb35b87a38640b0668974cb4ace68a66db
Cr-Commit-Position: refs/heads/master@{#381394}

[Dirk Pranke, 2016-03-16 03:01:17]

Patchset #1 (id:1) has been deleted

[jbudorick, 2016-03-16 03:03:43]

lgtm

[Dirk Pranke, 2016-03-16 03:05:35]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-03-16 03:05:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1803293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1803293002/20001

[commit-bot: I haz the power, 2016-03-16 05:24:10]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-03-16 05:26:33]

Description was changed from

==========
Only enforce the 'chromium' check in MB for the default config file.

r380254 introduced a bug where we would complain if *any* MB config
file did not have a 'chromium' master defined. We only want to
enforce that check in the Chromium repo.

This CL fixes that issue, and reworks the MB implementation a bit
so that we are handling return codes a bit more consistently.

R=dalecurtis@chromium.org, kjellander@chromium.org, jbudorick@chromium.org
BUG=
==========

to

==========
Only enforce the 'chromium' check in MB for the default config file.

r380254 introduced a bug where we would complain if *any* MB config
file did not have a 'chromium' master defined. We only want to
enforce that check in the Chromium repo.

This CL fixes that issue, and reworks the MB implementation a bit
so that we are handling return codes a bit more consistently.

R=dalecurtis@chromium.org, kjellander@chromium.org, jbudorick@chromium.org
BUG=

Committed: https://crrev.com/255085eb35b87a38640b0668974cb4ace68a66db
Cr-Commit-Position: refs/heads/master@{#381394}
==========

[commit-bot: I haz the power, 2016-03-16 05:26:34]

Patchset 1 (id:??) landed as
https://crrev.com/255085eb35b87a38640b0668974cb4ace68a66db
Cr-Commit-Position: refs/heads/master@{#381394}

[kjellander_chromium, 2016-03-16 13:12:40]

lgtm, thanks

[DaleCurtis, 2016-03-16 16:42:22]

lgtm

https://codereview.chromium.org/1803293002/diff/20001/tools/mb/mb_unittest.py
File tools/mb/mb_unittest.py (right):

https://codereview.chromium.org/1803293002/diff/20001/tools/mb/mb_unittest.py...
tools/mb/mb_unittest.py:183: TEST_BAD_CONFIG_ERR = """\
It doesn't look like this is used anymore; remove?