Only enforce the 'chromium' check in MB for the default config file.

tools/mb/mb.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """MB - the Meta-Build wrapper around GYP and GN
 
 MB is a wrapper script for GYP and GN that can be used to generate build files
 for sets of canned configurations and analyze them.
 """
@@ skipping 11 matching lines @@
 import shutil
 import sys
 import subprocess
 import tempfile
 import urllib2
 
 from collections import OrderedDict
 
 def main(args):
   mbw = MetaBuildWrapper()
-  mbw.ParseArgs(args)
-
-  try:
-    ret = mbw.args.func()
-    if ret:
-      mbw.DumpInputFiles()
-    return ret
-  except Exception:
-    mbw.DumpInputFiles()
-    raise
+  return mbw.Main(args)
 
 
 class MetaBuildWrapper(object):
   def __init__(self):
     p = os.path
     d = os.path.dirname
     self.chromium_src_dir = p.normpath(d(d(d(p.abspath(__file__)))))
     self.default_config = p.join(self.chromium_src_dir, 'tools', 'mb',
                                  'mb_config.pyl')
     self.executable = sys.executable
     self.platform = sys.platform
     self.sep = os.sep
     self.args = argparse.Namespace()
     self.configs = {}
     self.masters = {}
     self.mixins = {}
     self.private_configs = []
     self.common_dev_configs = []
     self.unsupported_configs = []
 
+  def Main(self, args):
+    self.ParseArgs(args)
+    try:
+      ret = self.args.func()
+      if ret:
+        self.DumpInputFiles()
+      return ret
+    except KeyboardInterrupt:
+      self.Print('interrupted, exiting', stream=sys.stderr)
+      return 130
+    except Exception as e:
+      self.DumpInputFiles()
+      self.Print(str(e))
+      return 1
+
   def ParseArgs(self, argv):
     def AddCommonOptions(subp):
       subp.add_argument('-b', '--builder',
                         help='builder name to look up config from')
       subp.add_argument('-m', '--master',
                         help='master name to look up config from')
       subp.add_argument('-c', '--config',
                         help='configuration to analyze')
       subp.add_argument('-f', '--config-file', metavar='PATH',
                         default=self.default_config,
@@ skipping 247 matching lines @@
         if not sub_mixin in self.mixins:
           errs.append('Unknown mixin "%s" referenced by mixin "%s".' %
                       (sub_mixin, mixin))
         referenced_mixins.add(sub_mixin)
 
     # Check that every mixin defined is actually referenced somewhere.
     for mixin in self.mixins:
       if not mixin in referenced_mixins:
         errs.append('Unreferenced mixin "%s".' % mixin)
 
-    # Check that 'chromium' bots which build public artifacts do not include
-    # the chrome_with_codecs 'mixin'.
-    if not 'chromium' in self.masters:
-      errs.append('Missing "chromium" master. Please update this proprietary '
-                  'codecs check with the name of the master responsible for '
-                  'public build artifacts.')
-    else:
-      for builder in self.masters['chromium']:
-        config = self.masters['chromium'][builder]
-        def RecurseMixins(current_mixin):
-          if current_mixin == 'chrome_with_codecs':
-            errs.append('Public artifact builder "%s" can not contain the '
-                        '"chrome_with_codecs" mixin.' % builder)
-            return
-          if not 'mixins' in self.mixins[current_mixin]:
-            return
-          for mixin in self.mixins[current_mixin]['mixins']:
+    # If we're checking the Chromium config, check that the 'chromium' bots
+    # which build public artifacts do not include the chrome_with_codecs mixin.
+    if self.args.config_file == self.default_config:
+      if 'chromium' in self.masters:
+        for builder in self.masters['chromium']:
+          config = self.masters['chromium'][builder]
+          def RecurseMixins(current_mixin):
+            if current_mixin == 'chrome_with_codecs':
+              errs.append('Public artifact builder "%s" can not contain the '
+                          '"chrome_with_codecs" mixin.' % builder)
+              return
+            if not 'mixins' in self.mixins[current_mixin]:
+              return
+            for mixin in self.mixins[current_mixin]['mixins']:
+              RecurseMixins(mixin)
+
+          for mixin in self.configs[config]:
             RecurseMixins(mixin)
-
-        for mixin in self.configs[config]:
-          RecurseMixins(mixin)
+      else:
+        errs.append('Missing "chromium" master. Please update this '
+                    'proprietary codecs check with the name of the master '
+                    'responsible for public build artifacts.')
 
     if errs:
       raise MBErr(('mb config file %s has problems:' % self.args.config_file) +
                     '\n  ' + '\n  '.join(errs))
 
     self.Print('mb config file %s looks ok.' % self.args.config_file)
     return 0
 
   def CmdAudit(self):
     """Track the progress of the GYP->GN migration on the bots."""
@@ skipping 937 matching lines @@
 
   # Then check to see if the arg contains any metacharacters other than
   # double quotes; if it does, quote everything (including the double
   # quotes) for safety.
   if any(a in UNSAFE_FOR_CMD for a in arg):
     arg = ''.join('^' + a if a in ALL_META_CHARS else a for a in arg)
   return arg
 
 
 if __name__ == '__main__':
-  try:
-    sys.exit(main(sys.argv[1:]))
-  except MBErr as e:
-    print(e)
-    sys.exit(1)
-  except KeyboardInterrupt:
-    print("interrupted, exiting", stream=sys.stderr)
-    sys.exit(130)
+  sys.exit(main(sys.argv[1:]))