base: Make RefCountedBytes::TakeVector return ref ptr instead of raw ptr

base: Make RefCountedBytes::TakeVector return ref ptr instead of raw ptr

This patch changes RefCountedBytes::TakeVector to return a ref ptr
instead of a raw pointer. This minimizes the changes of a leak if a
caller forgets to delete it, or forgets to wrap it in a ref ptr.

R=danakj@chromium.org, thakis@chromium.org
TBR=thakis@chromium.org
BUG=595163
Committed: https://crrev.com/219dc045a6270ee0563460417e04a95f48ee71dd
Cr-Commit-Position: refs/heads/master@{#381512}

[vmpstr, 2016-03-16 00:28:18]

Description was changed from

==========
base: Make RefCountedBytes::TakeVector return ref ptr instead of raw ptr

This patch changes RefCountedBytes::TakeVector to return a ref ptr
instead of a raw pointer. This minimizes the changes of a leak if a
caller forgets to delete it, or forgets to wrap it in a ref ptr.

R=danakj
BUG=595163
==========

to

==========
base: Make RefCountedBytes::TakeVector return ref ptr instead of raw ptr

This patch changes RefCountedBytes::TakeVector to return a ref ptr
instead of a raw pointer. This minimizes the changes of a leak if a
caller forgets to delete it, or forgets to wrap it in a ref ptr.

R=danakj@chromium.org, thakis@chromium.org
BUG=595163
==========

[vmpstr, 2016-03-16 00:28:18]

vmpstr@chromium.org changed reviewers:
+ thakis@chromium.org

[vmpstr, 2016-03-16 00:28:30]

Please take a look.

[danakj, 2016-03-16 00:31:33]

LGTM

[vmpstr, 2016-03-16 16:39:31]

Description was changed from

==========
base: Make RefCountedBytes::TakeVector return ref ptr instead of raw ptr

This patch changes RefCountedBytes::TakeVector to return a ref ptr
instead of a raw pointer. This minimizes the changes of a leak if a
caller forgets to delete it, or forgets to wrap it in a ref ptr.

R=danakj@chromium.org, thakis@chromium.org
BUG=595163
==========

to

==========
base: Make RefCountedBytes::TakeVector return ref ptr instead of raw ptr

This patch changes RefCountedBytes::TakeVector to return a ref ptr
instead of a raw pointer. This minimizes the changes of a leak if a
caller forgets to delete it, or forgets to wrap it in a ref ptr.

R=danakj@chromium.org, thakis@chromium.org
TBR=thakis@chromium.org
BUG=595163
==========

[vmpstr, 2016-03-16 16:39:57]

TBRing thakis@ for owners

[vmpstr, 2016-03-16 16:40:03]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-03-16 16:40:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1803263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1803263002/20001

[commit-bot: I haz the power, 2016-03-16 17:01:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 17:01:49]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[vmpstr, 2016-03-16 17:31:37]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-03-16 17:31:37]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1803263002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-03-16 17:32:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1803263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1803263002/40001

[commit-bot: I haz the power, 2016-03-16 19:38:41]

Description was changed from

==========
base: Make RefCountedBytes::TakeVector return ref ptr instead of raw ptr

This patch changes RefCountedBytes::TakeVector to return a ref ptr
instead of a raw pointer. This minimizes the changes of a leak if a
caller forgets to delete it, or forgets to wrap it in a ref ptr.

R=danakj@chromium.org, thakis@chromium.org
TBR=thakis@chromium.org
BUG=595163
==========

to

==========
base: Make RefCountedBytes::TakeVector return ref ptr instead of raw ptr

This patch changes RefCountedBytes::TakeVector to return a ref ptr
instead of a raw pointer. This minimizes the changes of a leak if a
caller forgets to delete it, or forgets to wrap it in a ref ptr.

R=danakj@chromium.org, thakis@chromium.org
TBR=thakis@chromium.org
BUG=595163
==========

[commit-bot: I haz the power, 2016-03-16 19:38:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-16 19:39:44]

Description was changed from

==========
base: Make RefCountedBytes::TakeVector return ref ptr instead of raw ptr

This patch changes RefCountedBytes::TakeVector to return a ref ptr
instead of a raw pointer. This minimizes the changes of a leak if a
caller forgets to delete it, or forgets to wrap it in a ref ptr.

R=danakj@chromium.org, thakis@chromium.org
TBR=thakis@chromium.org
BUG=595163
==========

to

==========
base: Make RefCountedBytes::TakeVector return ref ptr instead of raw ptr

This patch changes RefCountedBytes::TakeVector to return a ref ptr
instead of a raw pointer. This minimizes the changes of a leak if a
caller forgets to delete it, or forgets to wrap it in a ref ptr.

R=danakj@chromium.org, thakis@chromium.org
TBR=thakis@chromium.org
BUG=595163

Committed: https://crrev.com/219dc045a6270ee0563460417e04a95f48ee71dd
Cr-Commit-Position: refs/heads/master@{#381512}
==========

[commit-bot: I haz the power, 2016-03-16 19:39:45]

Patchset 3 (id:??) landed as
https://crrev.com/219dc045a6270ee0563460417e04a95f48ee71dd
Cr-Commit-Position: refs/heads/master@{#381512}

[Nico, 2016-03-18 21:25:36]

lgtm, nice!