chrome/browser/printing/print_preview_data_service.h - Issue 1803263002: base: Make RefCountedBytes::TakeVector return ref ptr instead of raw ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_data_service.h

Issue 1803263002: base: Make RefCountedBytes::TakeVector return ref ptr instead of raw ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/cloud_print/privet_http_unittest.cc ('k') | chrome/browser/printing/print_preview_data_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_preview_data_service.h

diff --git a/chrome/browser/printing/print_preview_data_service.h b/chrome/browser/printing/print_preview_data_service.h

index c5535811d4827849f07e88a10c54a2f4fb0d7f4b..9136c49b72acb04443ef4292dfed8caf703659f8 100644

--- a/chrome/browser/printing/print_preview_data_service.h

+++ b/chrome/browser/printing/print_preview_data_service.h

@@ -39,8 +39,9 @@ class PrintPreviewDataService {

// preview data. Use |index| to set/update a specific preview page data.

// NOTE: PrintPreviewDataStore owns the data. Do not refcount |data| before

// calling this function. It will be refcounted in PrintPreviewDataStore.

- void SetDataEntry(int32_t preview_ui_id, int index,

- const base::RefCountedBytes* data);

+ void SetDataEntry(int32_t preview_ui_id,

+ int index,

+ scoped_refptr<base::RefCountedBytes> data);

// Remove the corresponding PrintPreviewUI entry from the map.

void RemoveEntry(int32_t preview_ui_id);