Wait for store flush in CookieMonster::Delete*Task

net/cookies/cookie_monster.cc

Index: net/cookies/cookie_monster.cc
diff --git a/net/cookies/cookie_monster.cc b/net/cookies/cookie_monster.cc
index a17d5e7968c89e5b89c431994aeeb0e570c2bec3..b0cd6ee9378f80acd39ecacfeb3b01a20c4dd46f 100644
--- a/net/cookies/cookie_monster.cc
+++ b/net/cookies/cookie_monster.cc
@@ -591,8 +591,7 @@ void CookieMonster::DeleteAllCreatedBetweenTask::Run() {
   int num_deleted = this->cookie_monster()->
       DeleteAllCreatedBetween(delete_begin_, delete_end_);
   if (!callback_.is_null()) {
-    this->InvokeCallback(base::Bind(&CookieMonster::DeleteCallback::Run,
-                                    base::Unretained(&callback_), num_deleted));

[Randy Smith (Not in Mondays), 2013/06/27 14:30:20]

Erik: Why was the base::Unretained() here?  It gives me the heebee jeebees. 
Where's your lifetime guarantee if InvokeCallback hands this off to a different
thread?  Is there any place else in this file where we need to worry about this?

[erikwright (departed), 2013/07/17 16:53:32]

This was written prior to the ability to re-bind callbacks.

InvokeCallback, if it posts to another thread, posts a task that add-refs the
CookieMonsterTask. |callback_| is a member of CookierMonsterTask. So it is safe.

But rebinding is much better and it would be ideal to update this code to use
it.

+    this->cookie_monster()->FlushStore(base::Bind(callback_, num_deleted));

[erikwright (departed), 2013/07/17 16:53:32]

Instead of binding (callback_, num_deleted) directly, probably you should bind
(InvokeCallback, this, num_deleted).

That will restore the original thread guarantees.

   }
 }