Wait for store flush in CookieMonster::Delete*Task

net/cookies/cookie_monster.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Portions of this code based on Mozilla:
 //   (netwerk/cookie/src/nsCookieService.cpp)
 /* ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
  * The contents of this file are subject to the Mozilla Public License Version
@@ skipping 573 matching lines @@
   Time delete_end_;
   CookieMonster::DeleteCallback callback_;
 
   DISALLOW_COPY_AND_ASSIGN(DeleteAllCreatedBetweenTask);
 };
 
 void CookieMonster::DeleteAllCreatedBetweenTask::Run() {
   int num_deleted = this->cookie_monster()->
       DeleteAllCreatedBetween(delete_begin_, delete_end_);
   if (!callback_.is_null()) {
-    this->InvokeCallback(base::Bind(&CookieMonster::DeleteCallback::Run,
-                                    base::Unretained(&callback_), num_deleted));

[Randy Smith (Not in Mondays), 2013/06/27 14:30:20]

Erik: Why was the base::Unretained() here?  It gives me the heebee jeebees. 
Where's your lifetime guarantee if InvokeCallback hands this off to a different
thread?  Is there any place else in this file where we need to worry about this?

[erikwright (departed), 2013/07/17 16:53:32]

This was written prior to the ability to re-bind callbacks.

InvokeCallback, if it posts to another thread, posts a task that add-refs the
CookieMonsterTask. |callback_| is a member of CookierMonsterTask. So it is safe.

But rebinding is much better and it would be ideal to update this code to use
it.

+    this->cookie_monster()->FlushStore(base::Bind(callback_, num_deleted));

[erikwright (departed), 2013/07/17 16:53:32]

Instead of binding (callback_, num_deleted) directly, probably you should bind
(InvokeCallback, this, num_deleted).

That will restore the original thread guarantees.

   }
 }
 
 // Task class for DeleteAllForHost call.
 class CookieMonster::DeleteAllForHostTask
     : public CookieMonster::CookieMonsterTask {
  public:
   DeleteAllForHostTask(CookieMonster* cookie_monster,
                        const GURL& url,
                        const CookieMonster::DeleteCallback& callback)
@@ skipping 1544 matching lines @@
 
 // The system resolution is not high enough, so we can have multiple
 // set cookies that result in the same system time.  When this happens, we
 // increment by one Time unit.  Let's hope computers don't get too fast.
 Time CookieMonster::CurrentTime() {
   return std::max(Time::Now(),
       Time::FromInternalValue(last_time_seen_.ToInternalValue() + 1));
 }
 
 }  // namespace net