third_party/WebKit/Source/modules/webaudio/DelayNode.cpp - Issue 1803153002: Add min/max values for AudioParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/DelayNode.cpp

Issue 1803153002: Add min/max values for AudioParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/DelayNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/DelayNode.cpp b/third_party/WebKit/Source/modules/webaudio/DelayNode.cpp

index 4a3adf66229641fe3986b545afe8e37b1d3b88dd..bbe233fa531061e9ee5ed7e869576c0aebe15e30 100644

--- a/third_party/WebKit/Source/modules/webaudio/DelayNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/DelayNode.cpp

@@ -36,7 +36,7 @@ const double maximumAllowedDelayTime = 180;

DelayNode::DelayNode(AbstractAudioContext& context, float sampleRate, double maxDelayTime)

: AudioNode(context)

- , m_delayTime(AudioParam::create(context, ParamTypeDelayDelayTime, 0.0))

+ , m_delayTime(AudioParam::create(context, ParamTypeDelayDelayTime, 0.0, 0.0, maxDelayTime))

{

setHandler(AudioBasicProcessorHandler::create(AudioHandler::NodeTypeDelay, *this, sampleRate, adoptPtr(new DelayProcessor(sampleRate, 1, m_delayTime->handler(), maxDelayTime))));

}