third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp - Issue 1803153002: Add min/max values for AudioParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

Issue 1803153002: Add min/max values for AudioParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp b/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

index 8bd06ad39a5c4d126843505e907833f6e915402a..9d6fda8af8499eea982ab6358dd81ddedece67a7 100644

--- a/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

@@ -29,8 +29,8 @@ namespace blink {

BiquadFilterNode::BiquadFilterNode(AbstractAudioContext& context, float sampleRate)

: AudioNode(context)

- , m_frequency(AudioParam::create(context, ParamTypeBiquadFilterFrequency, 350.0))

- , m_q(AudioParam::create(context, ParamTypeBiquadFilterQ, 1))

+ , m_frequency(AudioParam::create(context, ParamTypeBiquadFilterFrequency, 350.0, 0, sampleRate / 2))

+ , m_q(AudioParam::create(context, ParamTypeBiquadFilterQ, 1.0))

, m_gain(AudioParam::create(context, ParamTypeBiquadFilterGain, 0.0))

, m_detune(AudioParam::create(context, ParamTypeBiquadFilterDetune, 0.0))

{