Replace BrowserProces::AddRefModule/RemoveModule by ScopedKeepAlive

chrome/browser/browser_process.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This interface is for managing the global services of the application. Each
 // service is lazily created when requested the first time. The service getters
 // will return NULL if the service is not available, so callers must check for
 // this condition.
 
 #ifndef CHROME_BROWSER_BROWSER_PROCESS_H_
@@ skipping 168 matching lines @@
   virtual IconManager* icon_manager() = 0;
 
   virtual GLStringManager* gl_string_manager() = 0;
 
   virtual GpuModeManager* gpu_mode_manager() = 0;
 
   virtual void CreateDevToolsHttpProtocolHandler(const std::string& ip,
                                                  uint16_t port) = 0;
   virtual void CreateDevToolsAutoOpener() = 0;
 
-  virtual unsigned int AddRefModule() = 0;
-  virtual unsigned int ReleaseModule() = 0;
+  // Called by KeepAliveRegistry to control Chrome's lifetime.
+  virtual void Pin() = 0;

[sky, 2016/03/16 16:04:32]

I don't like having these public as then anyone can call them, which we don't
want. How about having KeepAliveRegistry talk to a delegate that browserprocess
implements? That way you can make these protected.

[dgn, 2016/03/16 22:28:35]

Good idea, it also allows to get rid of a lot of code that disabled shutdown for
unit tests, by just not registering the listener in TestingBrowserProcess, which
is nice.

I used KeepAliveStateObserver to do it. WDYT? 

+  virtual void Unpin() = 0;
 
   virtual bool IsShuttingDown() = 0;
 
   virtual printing::PrintJobManager* print_job_manager() = 0;
   virtual printing::PrintPreviewDialogController*
       print_preview_dialog_controller() = 0;
   virtual printing::BackgroundPrintingManager*
       background_printing_manager() = 0;
 
   virtual IntranetRedirectDetector* intranet_redirect_detector() = 0;
@@ skipping 67 matching lines @@
   virtual shell_integration::DefaultWebClientState
   CachedDefaultWebClientState() = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowserProcess);
 };
 
 extern BrowserProcess* g_browser_process;
 
 #endif  // CHROME_BROWSER_BROWSER_PROCESS_H_