Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: chrome/browser/browser_process_impl.h

Issue 1803143002: Replace BrowserProces::AddRefModule/RemoveModule by ScopedKeepAlive (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // When each service is created, we set a flag indicating this. At this point, 5 // When each service is created, we set a flag indicating this. At this point,
6 // the service initialization could fail or succeed. This allows us to remember 6 // the service initialization could fail or succeed. This allows us to remember
7 // if we tried to create a service, and not try creating it over and over if 7 // if we tried to create a service, and not try creating it over and over if
8 // the creation failed. 8 // the creation failed.
9 9
10 #ifndef CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_ 10 #ifndef CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 NotificationUIManager* notification_ui_manager() override; 107 NotificationUIManager* notification_ui_manager() override;
108 message_center::MessageCenter* message_center() override; 108 message_center::MessageCenter* message_center() override;
109 policy::BrowserPolicyConnector* browser_policy_connector() override; 109 policy::BrowserPolicyConnector* browser_policy_connector() override;
110 policy::PolicyService* policy_service() override; 110 policy::PolicyService* policy_service() override;
111 IconManager* icon_manager() override; 111 IconManager* icon_manager() override;
112 GLStringManager* gl_string_manager() override; 112 GLStringManager* gl_string_manager() override;
113 GpuModeManager* gpu_mode_manager() override; 113 GpuModeManager* gpu_mode_manager() override;
114 void CreateDevToolsHttpProtocolHandler(const std::string& ip, 114 void CreateDevToolsHttpProtocolHandler(const std::string& ip,
115 uint16_t port) override; 115 uint16_t port) override;
116 void CreateDevToolsAutoOpener() override; 116 void CreateDevToolsAutoOpener() override;
117 unsigned int AddRefModule() override; 117 void Pin() override;
118 unsigned int ReleaseModule() override; 118 void Unpin() override;
119 bool IsShuttingDown() override; 119 bool IsShuttingDown() override;
120 printing::PrintJobManager* print_job_manager() override; 120 printing::PrintJobManager* print_job_manager() override;
121 printing::PrintPreviewDialogController* print_preview_dialog_controller() 121 printing::PrintPreviewDialogController* print_preview_dialog_controller()
122 override; 122 override;
123 printing::BackgroundPrintingManager* background_printing_manager() override; 123 printing::BackgroundPrintingManager* background_printing_manager() override;
124 IntranetRedirectDetector* intranet_redirect_detector() override; 124 IntranetRedirectDetector* intranet_redirect_detector() override;
125 const std::string& GetApplicationLocale() override; 125 const std::string& GetApplicationLocale() override;
126 void SetApplicationLocale(const std::string& locale) override; 126 void SetApplicationLocale(const std::string& locale) override;
127 DownloadStatusUpdater* download_status_updater() override; 127 DownloadStatusUpdater* download_status_updater() override;
128 DownloadRequestLimiter* download_request_limiter() override; 128 DownloadRequestLimiter* download_request_limiter() override;
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 235
236 scoped_ptr<StatusTray> status_tray_; 236 scoped_ptr<StatusTray> status_tray_;
237 237
238 #if BUILDFLAG(ENABLE_BACKGROUND) 238 #if BUILDFLAG(ENABLE_BACKGROUND)
239 scoped_ptr<BackgroundModeManager> background_mode_manager_; 239 scoped_ptr<BackgroundModeManager> background_mode_manager_;
240 #endif 240 #endif
241 241
242 bool created_safe_browsing_service_; 242 bool created_safe_browsing_service_;
243 scoped_refptr<safe_browsing::SafeBrowsingService> safe_browsing_service_; 243 scoped_refptr<safe_browsing::SafeBrowsingService> safe_browsing_service_;
244 244
245 unsigned int module_ref_count_; 245 bool shutting_down_;
246 bool did_start_;
247 246
248 bool tearing_down_; 247 bool tearing_down_;
249 248
250 // Ensures that all the print jobs are finished before closing the browser. 249 // Ensures that all the print jobs are finished before closing the browser.
251 scoped_ptr<printing::PrintJobManager> print_job_manager_; 250 scoped_ptr<printing::PrintJobManager> print_job_manager_;
252 251
253 std::string locale_; 252 std::string locale_;
254 253
255 // Download status updates (like a changing application icon on dock/taskbar) 254 // Download status updates (like a changing application icon on dock/taskbar)
256 // are global per-application. DownloadStatusUpdater does no work in the ctor 255 // are global per-application. DownloadStatusUpdater does no work in the ctor
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 // chrome/browser/memory/tab_manager_browsertest.cc 325 // chrome/browser/memory/tab_manager_browsertest.cc
327 scoped_ptr<memory::TabManager> tab_manager_; 326 scoped_ptr<memory::TabManager> tab_manager_;
328 #endif 327 #endif
329 328
330 shell_integration::DefaultWebClientState cached_default_web_client_state_; 329 shell_integration::DefaultWebClientState cached_default_web_client_state_;
331 330
332 DISALLOW_COPY_AND_ASSIGN(BrowserProcessImpl); 331 DISALLOW_COPY_AND_ASSIGN(BrowserProcessImpl);
333 }; 332 };
334 333
335 #endif // CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_ 334 #endif // CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698