Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1803043002: Reland "Fix sycc{420,422}_to_rgb issues." (Closed)

Created:
4 years, 9 months ago by Oliver Chang
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez, jun_fang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland "Fix sycc{420,422}_to_rgb issues." Fix an incorrect unit test result. This reverts commit 2df269c52741c12d63300cee806e96ae5d0b038f. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3cc180234c14639d408003c8180ba2963f0ea665

Patch Set 1 #

Patch Set 2 : fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M core/fxcodec/codec/fx_codec_jpx_opj.cpp View 3 chunks +23 lines, -15 lines 0 comments Download
M core/fxcodec/codec/fx_codec_jpx_unittest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Oliver Chang
Tom, ptal. PS#1 is original patch. PS#2 is the unit test fix. One of the ...
4 years, 9 months ago (2016-03-15 16:37:28 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-15 16:41:41 UTC) #3
Oliver Chang
4 years, 9 months ago (2016-03-15 16:47:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3cc180234c14639d408003c8180ba2963f0ea665 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698