Issue 1803043002: Reland "Fix sycc{420,422}_to_rgb issues."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1803043002: Reland "Fix sycc{420,422}_to_rgb issues." (Closed)

Created:
4 years, 9 months ago by Oliver Chang

Modified:
4 years, 9 months ago

Reviewers:
Tom Sepez, jun_fang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Reland "Fix sycc{420,422}_to_rgb issues." Fix an incorrect unit test result. This reverts commit 2df269c52741c12d63300cee806e96ae5d0b038f. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3cc180234c14639d408003c8180ba2963f0ea665

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -17 lines)			Patch
	M	core/fxcodec/codec/fx_codec_jpx_opj.cpp	View		3 chunks	+23 lines, -15 lines	0 comments	Download
	M	core/fxcodec/codec/fx_codec_jpx_unittest.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Oliver Chang

Tom, ptal. PS#1 is original patch. PS#2 is the unit test fix. One of the ...

4 years, 9 months ago (2016-03-15 16:37:28 UTC) #2

Oliver Chang

4 years, 9 months ago (2016-03-15 16:47:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3cc180234c14639d408003c8180ba2963f0ea665 (presubmit successful).