exo: Add support for secure_output interface to wayland bindings.

exo: Add support for secure_output interface to wayland bindings.

This makes it possible for a client to prevent surface contents
from appearing in screenshots or from being visible on
non-secure outputs.

This also removes some oom checks from server.cc that should have
been removed by: https://codereview.chromium.org/1717773002

BUG=549781
Committed: https://crrev.com/85b7a5676decceb6dbe2f1726a00f203b44d5eff
Cr-Commit-Position: refs/heads/master@{#381833}

[reveman, 2016-03-15 22:22:07]

reveman@chromium.org changed reviewers:
+ dcastagna@chromium.org

[reveman, 2016-03-16 14:36:12]

+ddorwin fyi

[reveman, 2016-03-16 22:09:12]

Description was changed from

==========
exo: Add support for secure_contents interface to wayland bindings.

BUG=549781
==========

to

==========
exo: Add support for secure_output interface to wayland bindings.

BUG=549781
==========

[reveman, 2016-03-16 22:09:25]

ptal

[Daniele Castagna, 2016-03-16 22:28:08]

You could also elaborate a little what this patch does in the description.

https://codereview.chromium.org/1802993003/diff/40001/components/exo/surface_...
File components/exo/surface_unittest.cc (right):

https://codereview.chromium.org/1802993003/diff/40001/components/exo/surface_...
components/exo/surface_unittest.cc:144: surface->Commit();
Test that the produced mailbox has the flag secure_output_only set to true?

https://codereview.chromium.org/1802993003/diff/40001/components/exo/wayland/...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/1802993003/diff/40001/components/exo/wayland/...
components/exo/wayland/server.cc:1882: client, &wl_viewport_interface,
wl_resource_get_version(resource), id);
Maybe mention this minor change in the description?

[reveman, 2016-03-17 16:28:42]

Description was changed from

==========
exo: Add support for secure_output interface to wayland bindings.

BUG=549781
==========

to

==========
exo: Add support for secure_output interface to wayland bindings.

This makes it possible for a client to prevent surface contents
from appearing in screenshots or from being visible on
non-secure outputs.

This also removes some oom checks from server.cc that should have
been removed by: https://codereview.chromium.org/1717773002

BUG=549781
==========

[reveman, 2016-03-17 16:36:32]

On 2016/03/16 at 22:28:08, dcastagna wrote:
> You could also elaborate a little what this patch does in the description.

Done.

https://codereview.chromium.org/1802993003/diff/40001/components/exo/surface_...
File components/exo/surface_unittest.cc (right):

https://codereview.chromium.org/1802993003/diff/40001/components/exo/surface_...
components/exo/surface_unittest.cc:144: surface->Commit();
On 2016/03/16 at 22:28:07, Daniele Castagna wrote:
> Test that the produced mailbox has the flag secure_output_only set to true?

Done.

https://codereview.chromium.org/1802993003/diff/40001/components/exo/wayland/...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/1802993003/diff/40001/components/exo/wayland/...
components/exo/wayland/server.cc:1882: client, &wl_viewport_interface,
wl_resource_get_version(resource), id);
On 2016/03/16 at 22:28:07, Daniele Castagna wrote:
> Maybe mention this minor change in the description?

Done.

[Daniele Castagna, 2016-03-17 16:45:19]

lgtm

[reveman, 2016-03-17 16:45:39]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2016-03-17 16:45:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1802993003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1802993003/60001

[commit-bot: I haz the power, 2016-03-17 18:36:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 18:36:07]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[reveman, 2016-03-17 18:54:41]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2016-03-17 18:55:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1802993003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1802993003/60001

[commit-bot: I haz the power, 2016-03-17 20:57:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 20:57:07]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[reveman, 2016-03-17 20:59:59]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2016-03-17 21:00:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1802993003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1802993003/60001

[commit-bot: I haz the power, 2016-03-17 23:27:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-17 23:29:04]

Description was changed from

==========
exo: Add support for secure_output interface to wayland bindings.

This makes it possible for a client to prevent surface contents
from appearing in screenshots or from being visible on
non-secure outputs.

This also removes some oom checks from server.cc that should have
been removed by: https://codereview.chromium.org/1717773002

BUG=549781
==========

to

==========
exo: Add support for secure_output interface to wayland bindings.

This makes it possible for a client to prevent surface contents
from appearing in screenshots or from being visible on
non-secure outputs.

This also removes some oom checks from server.cc that should have
been removed by: https://codereview.chromium.org/1717773002

BUG=549781

Committed: https://crrev.com/85b7a5676decceb6dbe2f1726a00f203b44d5eff
Cr-Commit-Position: refs/heads/master@{#381833}
==========

[commit-bot: I haz the power, 2016-03-17 23:29:05]

Patchset 4 (id:??) landed as
https://crrev.com/85b7a5676decceb6dbe2f1726a00f203b44d5eff
Cr-Commit-Position: refs/heads/master@{#381833}