Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1717773002: exo: Remove unnecessary wl_*_post_no_memory calls. (Closed)

Created:
4 years, 10 months ago by reveman
Modified:
4 years, 10 months ago
Reviewers:
lpique
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Remove unnecessary wl_*_post_no_memory calls. Chromium will crash when OOM. This removes all wl_*_post_no_memory calls that can't happen as a result of that. This also replaces the post_no_memory call in surface_attach with DLOG warning and sends more appropriate error messages to clients when failing to assign roles to surfaces. BUG=549781 TEST=exo_unittests Committed: https://crrev.com/38cd8f3f4cfe60f0365e9c3e251d1cf468fab73f Cr-Commit-Position: refs/heads/master@{#376579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -99 lines) Patch
M components/exo/wayland/server.cc View 23 chunks +14 lines, -99 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
reveman
4 years, 10 months ago (2016-02-19 20:23:49 UTC) #2
lpique
lgtm
4 years, 10 months ago (2016-02-19 23:33:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717773002/1
4 years, 10 months ago (2016-02-19 23:37:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-20 00:18:02 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-20 00:20:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38cd8f3f4cfe60f0365e9c3e251d1cf468fab73f
Cr-Commit-Position: refs/heads/master@{#376579}

Powered by Google App Engine
This is Rietveld 408576698