Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1802853002: 🚇GN: Fix ChromePublic.apk not rebuilding for native changes (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 9 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix ChromePublic.apk not rebuilding for native changes It was not being rebuilt when is_component_build=true, and the only change to the .apk's inputs was to an indirect .cr.so file. BUG=594409 Committed: https://crrev.com/57956cfb1d18e674f5fca36858f9336b0172f3c9 Cr-Commit-Position: refs/heads/master@{#381253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/gyp/write_build_config.py View 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
agrieve
On 2016/03/15 01:51:39, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:pkotwicz@chromium.org Looks like this ...
4 years, 9 months ago (2016-03-15 01:52:18 UTC) #3
pkotwicz
LGTM, thank you for fixing!
4 years, 9 months ago (2016-03-15 15:36:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802853002/1
4 years, 9 months ago (2016-03-15 16:54:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 18:12:51 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 18:14:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57956cfb1d18e674f5fca36858f9336b0172f3c9
Cr-Commit-Position: refs/heads/master@{#381253}

Powered by Google App Engine
This is Rietveld 408576698