Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2620)

Unified Diff: build/android/gyp/write_build_config.py

Issue 1802853002: 🚇GN: Fix ChromePublic.apk not rebuilding for native changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/write_build_config.py
diff --git a/build/android/gyp/write_build_config.py b/build/android/gyp/write_build_config.py
index baa535db6848fa78a9f283e847c6fb00f8fe968c..aad458f05cec64b768afeee280725a47993080c3 100755
--- a/build/android/gyp/write_build_config.py
+++ b/build/android/gyp/write_build_config.py
@@ -291,6 +291,7 @@ def main(argv):
options.type)
deps = Deps(direct_deps_config_paths)
+ all_inputs = deps.AllConfigPaths() + build_utils.GetPythonDependencies()
# Remove other locale resources if there is alternative_locale_resource in
# direct deps.
@@ -511,6 +512,7 @@ def main(argv):
prev_config['native']['java_libraries_list'])
library_paths.extend(prev_config['native']['libraries'])
+ all_inputs.extend(library_paths)
config['native'] = {
'libraries': library_paths,
'java_libraries_list': java_libraries_list_holder[0],
@@ -521,9 +523,7 @@ def main(argv):
build_utils.WriteJson(config, options.build_config, only_if_changed=True)
if options.depfile:
- build_utils.WriteDepfile(
- options.depfile,
- deps.AllConfigPaths() + build_utils.GetPythonDependencies())
+ build_utils.WriteDepfile(options.depfile, all_inputs)
if __name__ == '__main__':
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698