Issue 180283004: Add getReducedClipStack to lua canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180283004: Add getReducedClipStack to lua canvas (Closed)

Created:
6 years, 9 months ago by bsalomon

Modified:
6 years, 9 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add getReducedClipStack to lua canvas Committed: http://code.google.com/p/skia/source/detail?r=13594

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : make getTopLayer*() private #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -31 lines)			Patch
M	gyp/tools.gyp	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	include/core/SkCanvas.h	View	1 2	3 chunks	+16 lines, -5 lines	0 comments	Download
M	include/utils/SkLua.h	View	1 2	3 chunks	+5 lines, -1 line	0 comments	Download
M	src/core/SkCanvas.cpp	View		1 chunk	+11 lines, -1 line	0 comments	Download
M	src/core/SkTLList.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/utils/SkLua.cpp	View	1 2	5 chunks	+63 lines, -20 lines	0 comments	Download
M	tools/lua/dump_clipstack_at_restore.lua	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bsalomon

updated to make the getTopLayer*() methods private in SkCanvas.

6 years, 9 months ago (2014-02-26 15:58:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/180283004/30001

6 years, 9 months ago (2014-02-26 16:40:23 UTC) #5

bsalomon

6 years, 9 months ago (2014-02-26 18:32:09 UTC) #7

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/181653004/ by bsalomon@google.com.

The reason for reverting is: breaking a bunch of builds.

Expand Messages | Collapse Messages