Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1802743002: Deflake input_handler_proxy_unittest.cc. (Closed)

Created:
4 years, 9 months ago by tdresser
Modified:
4 years, 9 months ago
CC:
chromium-reviews, dtapuska+chromiumwatch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake input_handler_proxy_unittest.cc. Previously, there were cases where histogram tester and the statistics recorder would get out of sync. This ensures this never happens, by keeping the histogram tester alive throughout the duration of the tests. BUG=594606 Committed: https://crrev.com/58bd8b4abeb594f07120dc0c716796446b99d754 Cr-Commit-Position: refs/heads/master@{#381107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ui/events/blink/input_handler_proxy_unittest.cc View 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tdresser
This is cleaning up some flake introduced by https://codereview.chromium.org/1763713002. PTAL
4 years, 9 months ago (2016-03-14 20:25:22 UTC) #2
Reilly Grant (use Gerrit)
lgtm
4 years, 9 months ago (2016-03-14 20:42:12 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 9 months ago (2016-03-14 22:27:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802743002/1
4 years, 9 months ago (2016-03-14 22:42:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 23:23:02 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 23:24:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58bd8b4abeb594f07120dc0c716796446b99d754
Cr-Commit-Position: refs/heads/master@{#381107}

Powered by Google App Engine
This is Rietveld 408576698