Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2007)

Issue 1763713002: Added missing MainThreadScrollingReason in histograms.xml (Closed)

Created:
4 years, 9 months ago by tdresser
Modified:
4 years, 9 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, tdresser+watch_chromium.org, Ian Vollick, ymalik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added missing MainThreadScrollingReason in histograms.xml BUG=None Committed: https://crrev.com/fc32a32da4a897ba1552de764367e13bd079e245 Cr-Commit-Position: refs/heads/master@{#380694}

Patch Set 1 #

Patch Set 2 : Fix dependencies. #

Patch Set 3 : Undo gyp change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -5 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 6 chunks +31 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
tdresser
+isherman@ for histograms.xml +aelias@ for the rest I've added a small test ensuring that the ...
4 years, 9 months ago (2016-03-03 15:57:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763713002/1
4 years, 9 months ago (2016-03-03 15:57:43 UTC) #4
tdresser
+ymalik, vollick FYI
4 years, 9 months ago (2016-03-03 15:58:28 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/124967)
4 years, 9 months ago (2016-03-03 16:11:55 UTC) #7
Ilya Sherman
histograms.xml lgtm
4 years, 9 months ago (2016-03-03 23:39:51 UTC) #8
aelias_OOO_until_Jul13
lgtm
4 years, 9 months ago (2016-03-04 06:47:43 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763713002/20001
4 years, 9 months ago (2016-03-04 19:56:08 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/31672) android_compile_dbg on ...
4 years, 9 months ago (2016-03-04 20:02:11 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763713002/20001
4 years, 9 months ago (2016-03-11 15:40:49 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/106132) mac_chromium_compile_dbg_ng on ...
4 years, 9 months ago (2016-03-11 15:45:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763713002/40001
4 years, 9 months ago (2016-03-11 17:48:06 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-11 19:23:30 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 19:26:08 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fc32a32da4a897ba1552de764367e13bd079e245
Cr-Commit-Position: refs/heads/master@{#380694}

Powered by Google App Engine
This is Rietveld 408576698