Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1802733002: Move elements normalization to the ElementsAccessor (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move elements normalization to the ElementsAccessor This speeds up element normalization. BUG= Committed: https://crrev.com/b015dd11af153b71d11f5101613677b03d2f87a6 Cr-Commit-Position: refs/heads/master@{#34812}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -63 lines) Patch
M src/elements.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/elements.cc View 1 2 4 chunks +53 lines, -0 lines 0 comments Download
M src/objects.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 4 chunks +13 lines, -60 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-15 09:01:22 UTC) #2
Camillo Bruni
Don't you want to add all paths (also for dict-elements) for normalization? Makes things easier ...
4 years, 9 months ago (2016-03-15 13:12:22 UTC) #3
Toon Verwaest
ptal again
4 years, 9 months ago (2016-03-15 13:35:44 UTC) #4
Camillo Bruni
not sure if pretty, but certainly more correct :D lgtm
4 years, 9 months ago (2016-03-16 09:46:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802733002/40001
4 years, 9 months ago (2016-03-16 12:31:32 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-16 13:02:29 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 13:02:58 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b015dd11af153b71d11f5101613677b03d2f87a6
Cr-Commit-Position: refs/heads/master@{#34812}

Powered by Google App Engine
This is Rietveld 408576698