Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 180273020: UMA histograms to measure whether / how long blank text is rendered for loading web fonts (Closed)

Created:
6 years, 9 months ago by Kunihiko Sakamoto
Modified:
6 years, 9 months ago
Reviewers:
dglazkov, eae
CC:
blink-reviews, jamesr, krit, dsinclair, ed+blinkwatch_opera.com, jbroman, danakj, dglazkov+blink, Rik, apavlov+blink_chromium.org, darktears, Stephen Chennney, rune+blink, pdr., rwlbuis
Visibility:
Public.

Description

UMA histograms to measure whether / how long blank text is rendered for loading web fonts This patch adds two UMA metrics: WebFont.BlankTextShownTime histogram tracks the time we spent showing blank text. This measures the time between when the "loading fallback" font is drawn for the first time, and when FontData for the downloaded web font is created. WebFont.HadBlankText is recorded once per page load if the page uses any web fonts. The value is 1 if we ended up showing blank text at least once, 0 otherwise. BUG=345839 TEST=Manually tested with chrome://histograms Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168541

Patch Set 1 #

Total comments: 2

Patch Set 2 : early return #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -8 lines) Patch
M Source/core/css/CSSCustomFontData.h View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/css/CSSFontFace.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSFontFaceSource.h View 1 chunk +9 lines, -1 line 0 comments Download
M Source/core/css/CSSFontFaceSource.cpp View 1 3 chunks +17 lines, -0 lines 0 comments Download
M Source/core/css/FontFace.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/FontFace.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/css/FontFaceSet.h View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/css/FontFaceSet.cpp View 4 chunks +21 lines, -5 lines 0 comments Download
M Source/platform/fonts/CustomFontData.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Kunihiko Sakamoto
6 years, 9 months ago (2014-03-04 07:01:13 UTC) #1
dglazkov
lgtm https://codereview.chromium.org/180273020/diff/1/Source/core/css/CSSFontFaceSource.cpp File Source/core/css/CSSFontFaceSource.cpp (right): https://codereview.chromium.org/180273020/diff/1/Source/core/css/CSSFontFaceSource.cpp#newcode306 Source/core/css/CSSFontFaceSource.cpp:306: if (m_fallbackPaintTime > 0) { Early return?
6 years, 9 months ago (2014-03-04 17:24:08 UTC) #2
Kunihiko Sakamoto
https://codereview.chromium.org/180273020/diff/1/Source/core/css/CSSFontFaceSource.cpp File Source/core/css/CSSFontFaceSource.cpp (right): https://codereview.chromium.org/180273020/diff/1/Source/core/css/CSSFontFaceSource.cpp#newcode306 Source/core/css/CSSFontFaceSource.cpp:306: if (m_fallbackPaintTime > 0) { On 2014/03/04 17:24:08, Dimitri ...
6 years, 9 months ago (2014-03-05 08:55:59 UTC) #3
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org
6 years, 9 months ago (2014-03-05 08:56:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/180273020/20001
6 years, 9 months ago (2014-03-05 08:57:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/180273020/20001
6 years, 9 months ago (2014-03-05 20:57:27 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 22:19:55 UTC) #7
Message was sent while issue was closed.
Change committed as 168541

Powered by Google App Engine
This is Rietveld 408576698