Source/platform/fonts/CustomFontData.h - Issue 180273020: UMA histograms to measure whether / how long blank text is rendered for loading web fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/CustomFontData.h

Issue 180273020: UMA histograms to measure whether / how long blank text is rendered for loading web fonts (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: early return Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/CustomFontData.h

diff --git a/Source/platform/fonts/CustomFontData.h b/Source/platform/fonts/CustomFontData.h

index bb642c155fb1dbb4231036b2b0ab0f3f327fb752..40dce7483c96a241e46c46c7a3b5279391f25f87 100644

--- a/Source/platform/fonts/CustomFontData.h

+++ b/Source/platform/fonts/CustomFontData.h

@@ -48,7 +48,7 @@ public:

virtual void beginLoadIfNeeded() const { };

bool isLoading() const { return m_isLoadingFallback && m_isUsed; }

bool isLoadingFallback() const { return m_isLoadingFallback; }

- bool shouldSkipDrawing() const { return m_fallbackVisibility == InvisibleFallback && m_isUsed; }

+ virtual bool shouldSkipDrawing() const { return false; }

virtual bool isSVGFont() const { return false; }

virtual void initializeFontData(SimpleFontData*, float) { }

« no previous file with comments | « Source/core/css/FontFaceSet.cpp ('k') | no next file » | no next file with comments »