Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 180273003: Handle SSL timeouts in Rietveld requests. (Closed)

Created:
6 years, 10 months ago by Sergey Berezin
Modified:
6 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Handle SSL timeouts in Rietveld requests. BUG=346845 R=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=253271

Patch Set 1 #

Patch Set 2 : Removed extra parentheses #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M rietveld.py View 1 2 chunks +6 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Sergey Berezin
I believe we are seeing this new exception because of the other patch https://codereview.chromium.org/174313002
6 years, 10 months ago (2014-02-25 22:02:41 UTC) #1
M-A Ruel
lgtm https://codereview.chromium.org/180273003/diff/20001/rietveld.py File rietveld.py (right): https://codereview.chromium.org/180273003/diff/20001/rietveld.py#newcode409 rietveld.py:409: except ssl.SSLError, e: except ssl.SSLError as e:
6 years, 10 months ago (2014-02-25 22:09:41 UTC) #2
Sergey Berezin
The CQ bit was checked by sergeyberezin@chromium.org
6 years, 10 months ago (2014-02-25 22:33:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyberezin@chromium.org/180273003/20001
6 years, 10 months ago (2014-02-25 22:33:58 UTC) #4
commit-bot: I haz the power
Change committed as 253271
6 years, 10 months ago (2014-02-25 22:36:15 UTC) #5
Sergey Berezin
A revert of this CL has been created in https://codereview.chromium.org/177533020/ by sergeyberezin@chromium.org. The reason for ...
6 years, 10 months ago (2014-02-25 23:42:05 UTC) #6
Sergey Berezin
A revert of this CL has been created in https://codereview.chromium.org/180573003/ by sergeyberezin@chromium.org. The reason for ...
6 years, 10 months ago (2014-02-25 23:43:15 UTC) #7
iannucci
6 years, 10 months ago (2014-02-25 23:45:11 UTC) #8
Message was sent while issue was closed. 
On 2014/02/25 23:43:15, Sergey Berezin wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/180573003/ by
mailto:sergeyberezin@chromium.org.
> 
> The reason for reverting is: SSLError does not have a field 'reason'.
Reverting
> this, and I'll create another, correct patch after actually testing it
properly.
> Sorry..

You can be pretty much guaranteed that `str(e)` is something human-readable
though (no matter what Exception subclass it is)

Powered by Google App Engine
This is Rietveld 408576698