rietveld.py - Issue 180273003: Handle SSL timeouts in Rietveld requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rietveld.py

Issue 180273003: Handle SSL timeouts in Rietveld requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Removed extra parentheses Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: rietveld.py

diff --git a/rietveld.py b/rietveld.py

index 39cb19a9d7876c692bfdb41be9a798fc270d7510..9dfe8892b610dfca7c1707c47605e1f841da15e8 100644

--- a/rietveld.py

+++ b/rietveld.py

@@ -18,6 +18,7 @@ import copy

import json

import logging

import re

+import ssl

import time

import urllib2

@@ -405,6 +406,11 @@ class Rietveld(object):

not 'EOF occurred in violation of protocol' in e.reason):

# Usually internal GAE flakiness.

raise

+ except ssl.SSLError, e:

M-A Ruel 2014/02/25 22:09:41 except ssl.SSLError as e:

+ if retry >= (maxtries - 1):

+ raise

+ if not 'timed out' in e.reason:

+ raise

# If reaching this line, loop again. Uses a small backoff.

time.sleep(1+maxtries*2)

finally:

« no previous file with comments | « no previous file | no next file » | no next file with comments »