Move consumeColor and consumePosition to CSSPropertyParserHelpers

Move consumeColor and consumePosition to CSSPropertyParserHelpers

This patch moves the routines for consuming <color> and <position> out
of CSSPropertyParser.cpp and into CSSPropertyParserHelpers. We expect
that we'll require these routines for various Houdini APIs.

BUG=499780
Committed: https://crrev.com/86c916bd32eca8894407e890219882985b2e84b2
Cr-Commit-Position: refs/heads/master@{#381865}

[Timothy Loh, 2016-03-15 03:59:41]

timloh@chromium.org changed reviewers:
+ dstockwell@chromium.org, rob.buis@samsung.com

[Timothy Loh, 2016-03-15 03:59:41]

https://codereview.chromium.org/1802673003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
(right):

https://codereview.chromium.org/1802673003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp:413: //
TODO(timloh): This should check the numericValueType flag
I added a TODO here, this would fix the remaining test failures on
http://w3c-test.org/quirks-mode/hashless-hex-color.html

https://codereview.chromium.org/1802673003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp:548: //
TODO(timloh): This may consume from the range upon failure. The background
I changed the previous comment into this TODO.

[rwlbuis, 2016-03-17 15:24:20]

Sorry, I somehow missed this!

PTAL.

[rwlbuis, 2016-03-17 15:25:07]

On 2016/03/17 15:24:20, rwlbuis wrote:
> Sorry, I somehow missed this!
> 
> PTAL.

Ugh, need more coffee :) I meant LGTM.

[Timothy Loh, 2016-03-17 23:10:11]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2016-03-17 23:10:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1802673003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1802673003/1

[commit-bot: I haz the power, 2016-03-18 01:39:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-18 01:41:09]

Description was changed from

==========
Move consumeColor and consumePosition to CSSPropertyParserHelpers

This patch moves the routines for consuming <color> and <position> out
of CSSPropertyParser.cpp and into CSSPropertyParserHelpers. We expect
that we'll require these routines for various Houdini APIs.

BUG=499780
==========

to

==========
Move consumeColor and consumePosition to CSSPropertyParserHelpers

This patch moves the routines for consuming <color> and <position> out
of CSSPropertyParser.cpp and into CSSPropertyParserHelpers. We expect
that we'll require these routines for various Houdini APIs.

BUG=499780

Committed: https://crrev.com/86c916bd32eca8894407e890219882985b2e84b2
Cr-Commit-Position: refs/heads/master@{#381865}
==========

[commit-bot: I haz the power, 2016-03-18 01:41:10]

Patchset 1 (id:??) landed as
https://crrev.com/86c916bd32eca8894407e890219882985b2e84b2
Cr-Commit-Position: refs/heads/master@{#381865}