third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h - Issue 1802673003: Move consumeColor and consumePosition to CSSPropertyParserHelpers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Issue 1802673003: Move consumeColor and consumePosition to CSSPropertyParserHelpers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

index b36dfdfbd4bdc37d5fd509abb6e86f98706dde0c..2a641407f57966f06f291a5ad521903423ec1e75 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

@@ -23,7 +23,6 @@

#ifndef CSSPropertyParser_h

#define CSSPropertyParser_h

-#include "core/css/CSSColorValue.h"

#include "core/css/CSSGridTemplateAreasValue.h"

#include "core/css/StyleRule.h"

#include "core/css/parser/CSSParserTokenRange.h"

@@ -74,6 +73,7 @@ public:

// Parses a non-shorthand CSS property

static PassRefPtrWillBeRawPtr<CSSValue> parseSingleValue(CSSPropertyID, const CSSParserTokenRange&, const CSSParserContext&);

+ // TODO(timloh): This doesn't seem like the right place for these

static bool isSystemColor(CSSValueID);

static bool isColorKeyword(CSSValueID);

static bool isValidNumericValue(double);