Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1802553003: Fix Google3 build by updating pdf path after https://codereview.chromium.org/1781773002 (Closed)

Created:
4 years, 9 months ago by dogben
Modified:
4 years, 9 months ago
Reviewers:
hal.canary
CC:
jcgregorio, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment. #

Patch Set 3 : Update comment again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M public.bzl View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802553003/1
4 years, 9 months ago (2016-03-14 17:02:39 UTC) #3
dogben
4 years, 9 months ago (2016-03-14 17:02:54 UTC) #5
hal.canary
Lgtm https://codereview.chromium.org/1802553003/diff/1/public.bzl File public.bzl (right): https://codereview.chromium.org/1802553003/diff/1/public.bzl#newcode97 public.bzl:97: "src/pdf/SkDocument_PDF_None.cpp", # We use SkDocument_PDF.cpp. Please update comment.
4 years, 9 months ago (2016-03-14 17:05:17 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-14 17:11:30 UTC) #8
dogben
https://codereview.chromium.org/1802553003/diff/1/public.bzl File public.bzl (right): https://codereview.chromium.org/1802553003/diff/1/public.bzl#newcode97 public.bzl:97: "src/pdf/SkDocument_PDF_None.cpp", # We use SkDocument_PDF.cpp. On 2016/03/14 at 17:05:17, ...
4 years, 9 months ago (2016-03-14 21:13:28 UTC) #9
hal.canary
On 2016/03/14 21:13:28, Ben Wagner wrote: > https://codereview.chromium.org/1802553003/diff/1/public.bzl > File public.bzl (right): > > https://codereview.chromium.org/1802553003/diff/1/public.bzl#newcode97 ...
4 years, 9 months ago (2016-03-14 22:03:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802553003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802553003/40001
4 years, 9 months ago (2016-03-14 22:11:58 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 22:21:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ca26a180c3993346c40dd9b7fc6daf8b5224f0cd

Powered by Google App Engine
This is Rietveld 408576698