Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1781773002: SkPDF: move all pdf sources into src/pdf (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: move all pdf sources into src/pdf also, consolidate XPS backend into src/xps remove from include/ almost always a good thing. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1781773002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/23f4d4d1b9151bb89cdced9986be7ec9b006d458

Patch Set 1 : 2016-03-09 (Wednesday) 14:30:18 EST #

Patch Set 2 : 2016-03-10 (Thursday) 15:59:02 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3272 lines) Patch
M cmake/CMakeLists.txt View 1 1 chunk +3 lines, -2 lines 0 comments Download
M gyp/core.gypi View 1 2 chunks +1 line, -2 lines 0 comments Download
M gyp/pdf.gyp View 1 2 chunks +1 line, -2 lines 0 comments Download
M gyp/pdf.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M gyp/xps.gyp View 1 2 chunks +5 lines, -6 lines 0 comments Download
D include/device/xps/SkConstexprMath.h View 1 1 chunk +0 lines, -54 lines 0 comments Download
D include/device/xps/SkXPSDevice.h View 1 1 chunk +0 lines, -324 lines 0 comments Download
A + src/core/SkDocument.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D src/device/xps/SkXPSDevice.cpp View 1 1 chunk +0 lines, -2267 lines 0 comments Download
D src/doc/SkDocument.cpp View 1 1 chunk +0 lines, -95 lines 0 comments Download
D src/doc/SkDocument_PDF.cpp View 1 chunk +0 lines, -403 lines 0 comments Download
D src/doc/SkDocument_PDF_None.cpp View 1 1 chunk +0 lines, -9 lines 0 comments Download
D src/doc/SkDocument_XPS.cpp View 1 1 chunk +0 lines, -82 lines 0 comments Download
D src/doc/SkDocument_XPS_None.cpp View 1 1 chunk +0 lines, -15 lines 0 comments Download
A + src/pdf/SkDocument_PDF_None.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A src/pdf/SkPDFDocument.h View 1 chunk +18 lines, -0 lines 0 comments Download
A + src/pdf/SkPDFDocument.cpp View 4 chunks +18 lines, -17 lines 0 comments Download
A + src/xps/SkConstexprMath.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/xps/SkDocument_XPS.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/xps/SkDocument_XPS_None.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/xps/SkXPSDevice.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/xps/SkXPSDevice.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 28 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781773002/20001
4 years, 9 months ago (2016-03-09 19:33:03 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 19:55:14 UTC) #7
hal.canary
I just want the entire module in its own directory for easy grepping.
4 years, 9 months ago (2016-03-09 20:14:25 UTC) #9
reed1
interesting. should we eliminate the src/doc directory, or should we keep it with the other ...
4 years, 9 months ago (2016-03-09 20:16:46 UTC) #11
hal.canary
On 2016/03/09 20:16:46, reed1 wrote: > interesting. should we eliminate the src/doc directory, or should ...
4 years, 9 months ago (2016-03-09 20:31:56 UTC) #12
hal.canary
ping
4 years, 9 months ago (2016-03-10 18:45:10 UTC) #13
bungeman-skia
lgtm
4 years, 9 months ago (2016-03-10 19:18:22 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781773002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781773002/60001
4 years, 9 months ago (2016-03-10 20:59:26 UTC) #17
hal.canary
Okay, src/doc is no more.
4 years, 9 months ago (2016-03-10 20:59:56 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 21:15:13 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781773002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781773002/60001
4 years, 9 months ago (2016-03-12 13:50:06 UTC) #26
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 13:59:43 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://skia.googlesource.com/skia/+/23f4d4d1b9151bb89cdced9986be7ec9b006d458

Powered by Google App Engine
This is Rietveld 408576698