Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 180253006: Merge 252257 "events: Fix event-targeting for transformed windows." (Closed)

Created:
6 years, 10 months ago by sadrul
Modified:
6 years, 10 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, ben+aura_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Merge 252257 "events: Fix event-targeting for transformed windows." > events: Fix event-targeting for transformed windows. > > Applying the transforms on a Window's bounds does not give the correct transformed > bounds of the window in its parent's coordinate system. For example, a Window with > size 300x200 at position 20,10 and scaled at 50% has bounds (20, 10, 150, 100), and > not (10, 5, 150, 100). So remove this transform from the window-targeting code, and > instead convert the event's location to be in the child Window's coordinate system > when doing hit-testing. > > This fixes selecting windows when in overview mode. > > BUG=339834 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/167323004 TBR=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -13 lines) Patch
ash/wm/overview/window_selector_unittest.cc View 2 chunks +46 lines, -0 lines 0 comments Download
ui/aura/window_targeter.cc View 1 chunk +4 lines, -4 lines 0 comments Download
ui/aura/window_targeter_unittest.cc View 2 chunks +56 lines, -0 lines 0 comments Download
ui/wm/core/easy_resize_window_targeter.cc View 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
6 years, 10 months ago (2014-02-26 00:02:51 UTC) #1
sadrul
6 years, 10 months ago (2014-02-26 00:03:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r253297.

Powered by Google App Engine
This is Rietveld 408576698