Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 167323004: events: Fix event-targeting for transformed windows. (Closed)

Created:
6 years, 10 months ago by sadrul
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, ben+aura_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

events: Fix event-targeting for transformed windows. Applying the transforms on a Window's bounds does not give the correct transformed bounds of the window in its parent's coordinate system. For example, a Window with size 300x200 at position 20,10 and scaled at 50% has bounds (20, 10, 150, 100), and not (10, 5, 150, 100). So remove this transform from the window-targeting code, and instead convert the event's location to be in the child Window's coordinate system when doing hit-testing. This fixes selecting windows when in overview mode. BUG=339834 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252257

Patch Set 1 #

Patch Set 2 : self-nits #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -13 lines) Patch
M ash/wm/overview/window_selector_unittest.cc View 1 2 chunks +46 lines, -0 lines 0 comments Download
M ui/aura/window_targeter.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/aura/window_targeter_unittest.cc View 1 2 chunks +56 lines, -0 lines 3 comments Download
M ui/wm/core/easy_resize_window_targeter.cc View 1 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
https://codereview.chromium.org/167323004/diff/90001/ui/aura/window_targeter_unittest.cc File ui/aura/window_targeter_unittest.cc (right): https://codereview.chromium.org/167323004/diff/90001/ui/aura/window_targeter_unittest.cc#newcode43 ui/aura/window_targeter_unittest.cc:43: gfx::RectF GetEffectiveVisibleBoundsInRootWindow(Window* window) { I wonder if aura::Window::GetBoundsInScreen()/GetBoundsInRootWindow() should ...
6 years, 10 months ago (2014-02-20 00:58:12 UTC) #1
sky
https://codereview.chromium.org/167323004/diff/90001/ui/aura/window_targeter_unittest.cc File ui/aura/window_targeter_unittest.cc (right): https://codereview.chromium.org/167323004/diff/90001/ui/aura/window_targeter_unittest.cc#newcode43 ui/aura/window_targeter_unittest.cc:43: gfx::RectF GetEffectiveVisibleBoundsInRootWindow(Window* window) { On 2014/02/20 00:58:13, sadrul wrote: ...
6 years, 10 months ago (2014-02-20 01:33:00 UTC) #2
sadrul
https://codereview.chromium.org/167323004/diff/90001/ui/aura/window_targeter_unittest.cc File ui/aura/window_targeter_unittest.cc (right): https://codereview.chromium.org/167323004/diff/90001/ui/aura/window_targeter_unittest.cc#newcode43 ui/aura/window_targeter_unittest.cc:43: gfx::RectF GetEffectiveVisibleBoundsInRootWindow(Window* window) { On 2014/02/20 01:33:01, sky wrote: ...
6 years, 10 months ago (2014-02-20 04:16:52 UTC) #3
sky
Ok, LGTM
6 years, 10 months ago (2014-02-20 15:49:02 UTC) #4
sadrul
6 years, 10 months ago (2014-02-20 16:12:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r252257 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698