Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: ui/app_list/app_list_view_delegate.h

Issue 1802473002: Add deprecation warning banner to App Launcher on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20170310-MacViews-ViewsUnittests
Patch Set: self nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/app_list/app_list_view_delegate.h
diff --git a/ui/app_list/app_list_view_delegate.h b/ui/app_list/app_list_view_delegate.h
index 69462e78e42e6304b9d44d3980fc00fd878a0535..625463381a767153ad5571d5c03b1a03e8c77aa1 100644
--- a/ui/app_list/app_list_view_delegate.h
+++ b/ui/app_list/app_list_view_delegate.h
@@ -165,6 +165,18 @@ class APP_LIST_EXPORT AppListViewDelegate {
// Adds/removes an observer for profile changes.
virtual void AddObserver(AppListViewDelegateObserver* observer) {}
virtual void RemoveObserver(AppListViewDelegateObserver* observer) {}
+
+#if !defined(OS_CHROMEOS)
+ // Methods to retrieve properties of the message displayed on the app launcher
+ // above the apps grid.
+ virtual base::string16 GetMessageTitle() const;
Matt Giuca 2016/03/22 03:56:15 Also I think these should be =0 and add overrides
tapted 2016/03/22 04:19:50 There's precedent for impure virtuals already for
Matt Giuca 2016/03/22 04:23:43 That isn't precedent in my mind -- observers shoul
+ virtual base::string16 GetMessageText() const;
Matt Giuca 2016/03/22 03:28:06 // Returns the message text (with the placeholder
tapted 2016/03/22 04:58:14 Acknowledged.
+ virtual base::string16 GetAppsShortcutName() const;
+ virtual base::string16 GetLearnMoreText() const;
+ virtual base::string16 GetLearnMoreLink() const;
+ virtual gfx::ImageSkia* GetAppsIcon() const;
+ virtual void OpenLearnMoreLink();
+#endif
};
} // namespace app_list

Powered by Google App Engine
This is Rietveld 408576698