Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: ui/app_list/app_list_view_delegate.h

Issue 1802473002: Add deprecation warning banner to App Launcher on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20170310-MacViews-ViewsUnittests
Patch Set: self nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_APP_LIST_APP_LIST_VIEW_DELEGATE_H_ 5 #ifndef UI_APP_LIST_APP_LIST_VIEW_DELEGATE_H_
6 #define UI_APP_LIST_APP_LIST_VIEW_DELEGATE_H_ 6 #define UI_APP_LIST_APP_LIST_VIEW_DELEGATE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 158
159 // Returns the list of users (for AppListMenu). 159 // Returns the list of users (for AppListMenu).
160 virtual const Users& GetUsers() const = 0; 160 virtual const Users& GetUsers() const = 0;
161 161
162 // Returns true if the app list should be centered and in landscape mode. 162 // Returns true if the app list should be centered and in landscape mode.
163 virtual bool ShouldCenterWindow() const = 0; 163 virtual bool ShouldCenterWindow() const = 0;
164 164
165 // Adds/removes an observer for profile changes. 165 // Adds/removes an observer for profile changes.
166 virtual void AddObserver(AppListViewDelegateObserver* observer) {} 166 virtual void AddObserver(AppListViewDelegateObserver* observer) {}
167 virtual void RemoveObserver(AppListViewDelegateObserver* observer) {} 167 virtual void RemoveObserver(AppListViewDelegateObserver* observer) {}
168
169 #if !defined(OS_CHROMEOS)
170 // Methods to retrieve properties of the message displayed on the app launcher
171 // above the apps grid.
172 virtual base::string16 GetMessageTitle() const;
Matt Giuca 2016/03/22 03:56:15 Also I think these should be =0 and add overrides
tapted 2016/03/22 04:19:50 There's precedent for impure virtuals already for
Matt Giuca 2016/03/22 04:23:43 That isn't precedent in my mind -- observers shoul
173 virtual base::string16 GetMessageText() const;
Matt Giuca 2016/03/22 03:28:06 // Returns the message text (with the placeholder
tapted 2016/03/22 04:58:14 Acknowledged.
174 virtual base::string16 GetAppsShortcutName() const;
175 virtual base::string16 GetLearnMoreText() const;
176 virtual base::string16 GetLearnMoreLink() const;
177 virtual gfx::ImageSkia* GetAppsIcon() const;
178 virtual void OpenLearnMoreLink();
179 #endif
168 }; 180 };
169 181
170 } // namespace app_list 182 } // namespace app_list
171 183
172 #endif // UI_APP_LIST_APP_LIST_VIEW_DELEGATE_H_ 184 #endif // UI_APP_LIST_APP_LIST_VIEW_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698