Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 180243018: Remove SVGAnimatedProperty::animatedPropertyCache (Closed)

Created:
6 years, 9 months ago by rwlbuis
Modified:
6 years, 9 months ago
CC:
blink-reviews, Steve Block, krit, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), fs, Timothy Loh, dstockwell, ed+blinkwatch_opera.com, shans, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Eric Willigers, dino_apple.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove animatedPropertyCache from SVGAnimatedProperty, it is not needed anymore because of the new animated property system. This is the first item on the removal TODO. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -140 lines) Patch
M Source/core/svg/SVGElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.h View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.cpp View 2 chunks +0 lines, -30 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedPropertyMacros.h View 2 chunks +0 lines, -76 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rwlbuis
This is the first item on the removal TODO, as discussed.
6 years, 9 months ago (2014-02-27 21:12:47 UTC) #1
pdr.
On 2014/02/27 21:12:47, rwlbuis wrote: > This is the first item on the removal TODO, ...
6 years, 9 months ago (2014-02-27 21:53:15 UTC) #2
pdr.
On 2014/02/27 21:53:15, pdr wrote: > On 2014/02/27 21:12:47, rwlbuis wrote: > > This is ...
6 years, 9 months ago (2014-02-27 21:53:45 UTC) #3
rwlbuis
On 2014/02/27 21:53:45, pdr wrote: Hi Philip, the CL is closed, was this on purpose ...
6 years, 9 months ago (2014-02-27 21:58:21 UTC) #4
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-02-27 22:34:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/180243018/1
6 years, 9 months ago (2014-02-27 22:34:27 UTC) #6
pdr.
On 2014/02/27 21:58:21, rwlbuis wrote: > On 2014/02/27 21:53:45, pdr wrote: > > Hi Philip, ...
6 years, 9 months ago (2014-02-27 22:35:43 UTC) #7
kouhei (in TOK)
lgtm Wow! Thanks! lgtm
6 years, 9 months ago (2014-02-27 22:55:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/180243018/1
6 years, 9 months ago (2014-02-28 01:06:30 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 01:26:19 UTC) #10
Message was sent while issue was closed.
Change committed as 168070

Powered by Google App Engine
This is Rietveld 408576698