Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: Source/core/svg/SVGElement.cpp

Issue 180243018: Remove SVGAnimatedProperty::animatedPropertyCache (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/svg/properties/SVGAnimatedProperty.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org> 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>
3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 5 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 // modifying the rare data map. Do not rely on the existing iterator. 118 // modifying the rare data map. Do not rely on the existing iterator.
119 ASSERT(rareDataMap.contains(this)); 119 ASSERT(rareDataMap.contains(this));
120 rareDataMap.remove(this); 120 rareDataMap.remove(this);
121 // Clear HasSVGRareData flag now so that we are in a consistent state wh en 121 // Clear HasSVGRareData flag now so that we are in a consistent state wh en
122 // calling rebuildAllElementReferencesForTarget() and 122 // calling rebuildAllElementReferencesForTarget() and
123 // removeAllElementReferencesForTarget() below. 123 // removeAllElementReferencesForTarget() below.
124 clearHasSVGRareData(); 124 clearHasSVGRareData();
125 } 125 }
126 document().accessSVGExtensions().rebuildAllElementReferencesForTarget(this); 126 document().accessSVGExtensions().rebuildAllElementReferencesForTarget(this);
127 document().accessSVGExtensions().removeAllElementReferencesForTarget(this); 127 document().accessSVGExtensions().removeAllElementReferencesForTarget(this);
128 SVGAnimatedProperty::detachAnimatedPropertiesForElement(this);
129 } 128 }
130 129
131 void SVGElement::willRecalcStyle(StyleRecalcChange change) 130 void SVGElement::willRecalcStyle(StyleRecalcChange change)
132 { 131 {
133 // FIXME: This assumes that when shouldNotifyRendererWithIdenticalStyles() i s true 132 // FIXME: This assumes that when shouldNotifyRendererWithIdenticalStyles() i s true
134 // the change came from a SMIL animation, but what if there were non-SMIL ch anges 133 // the change came from a SMIL animation, but what if there were non-SMIL ch anges
135 // since then? I think we should remove the shouldNotifyRendererWithIdentica lStyles 134 // since then? I think we should remove the shouldNotifyRendererWithIdentica lStyles
136 // check. 135 // check.
137 if (!hasSVGRareData() || shouldNotifyRendererWithIdenticalStyles()) 136 if (!hasSVGRareData() || shouldNotifyRendererWithIdenticalStyles())
138 return; 137 return;
(...skipping 1034 matching lines...) Expand 10 before | Expand all | Expand 10 after
1173 animatableAttributes.add(SVGNames::zAttr); 1172 animatableAttributes.add(SVGNames::zAttr);
1174 } 1173 }
1175 1174
1176 if (name == classAttr) 1175 if (name == classAttr)
1177 return true; 1176 return true;
1178 1177
1179 return animatableAttributes.contains(name); 1178 return animatableAttributes.contains(name);
1180 } 1179 }
1181 #endif 1180 #endif
1182 } 1181 }
OLDNEW
« no previous file with comments | « no previous file | Source/core/svg/properties/SVGAnimatedProperty.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698