Add the new window item to the Files.app's context menu on the launcher.

Add the new window item to the Files.app's context menu on the launcher.

This patch adds the 'Open new window' item to the context menu after right clicking on the launcher, which opens a new Files.app window on the same path as the focused window.
Along the way, the obsolete code for opening a new window has been removed and the bug with not remembering the last path has been resolved.

TEST=Open new window via the gear button as well as the context menu.
BUG=252177, 254823
R=benwells@chromium.org, hashimoto@chromium.org, yoshiki@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209120

[mtomasz, 2013-06-27 07:50:18]

@hashimoto: PTAL at C++
@yoshiki: PTAL at Javascript.

Thanks!

[hashimoto, 2013-06-27 09:17:55]

chrome/browser/chromeos/extensions/ lgtm

[yoshiki, 2013-06-27 10:25:40]

https://codereview.chromium.org/18024002/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://codereview.chromium.org/18024002/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:793:
chrome.storage.local.get('strings', function(items) {
If Files.app is launched via chrome://files (it means background.js is not
loaded), we can't fetch the string. Is this change necessary for this patch?

[mtomasz, 2013-06-27 10:26:57]

https://codereview.chromium.org/18024002/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://codereview.chromium.org/18024002/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:793:
chrome.storage.local.get('strings', function(items) {
On 2013/06/27 10:25:40, yoshiki wrote:
> If Files.app is launched via chrome://files (it means background.js is not
> loaded), we can't fetch the string. Is this change necessary for this patch?

Good catch. I'll fix it. We need the strings here, to add the context menu to
the launcher.

[mtomasz, 2013-06-27 12:03:09]

https://codereview.chromium.org/18024002/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://codereview.chromium.org/18024002/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:793:
chrome.storage.local.get('strings', function(items) {
On 2013/06/27 10:26:57, mtomasz wrote:
> On 2013/06/27 10:25:40, yoshiki wrote:
> > If Files.app is launched via chrome://files (it means background.js is not
> > loaded), we can't fetch the string. Is this change necessary for this patch?
> 
> Good catch. I'll fix it. We need the strings here, to add the context menu to
> the launcher.

Done.

[yoshiki, 2013-06-27 15:23:08]

Thanks! LGTM

[commit-bot: I haz the power, 2013-06-27 15:27:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/18024002/7001

[commit-bot: I haz the power, 2013-06-27 15:45:12]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-06-27 15:49:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/18024002/7001

[commit-bot: I haz the power, 2013-06-27 15:58:59]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[mtomasz, 2013-06-28 02:45:43]

@benwells: PTAL at extension_function_histogram_value.h and
file_browser_private.json. Thanks.

[benwells, 2013-06-28 05:37:41]

lgtm

[commit-bot: I haz the power, 2013-06-28 05:38:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/18024002/7001

[mtomasz, 2013-06-28 07:57:42]

Committed patchset #2 manually as r209120 (presubmit successful).