Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5333)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc

Issue 18024002: Add the new window item to the Files.app's context menu on the launcher. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments + fixed. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc b/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc
index b3f9e14beb39891e4455358fb6b028ab0c657b9a..36c99e97ff11b5aeaec1f12841013603e4b71419 100644
--- a/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc
@@ -452,7 +452,6 @@ FileBrowserPrivateAPI::FileBrowserPrivateAPI(Profile* profile)
registry->RegisterFunction<SetLastModifiedFunction>();
registry->RegisterFunction<ZipSelectionFunction>();
registry->RegisterFunction<ValidatePathNameLengthFunction>();
- registry->RegisterFunction<OpenNewWindowFunction>();
registry->RegisterFunction<ZoomFunction>();
event_router_->ObserveFileSystemEvents();
}
@@ -3084,17 +3083,6 @@ void ValidatePathNameLengthFunction::OnFilePathLimitRetrieved(
SendResponse(true);
}
-OpenNewWindowFunction::OpenNewWindowFunction() {}
-
-OpenNewWindowFunction::~OpenNewWindowFunction() {}
-
-bool OpenNewWindowFunction::RunImpl() {
- std::string url;
- EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &url));
- file_manager_util::OpenNewWindow(profile_, GURL(url));
- return true;
-}
-
bool ZoomFunction::RunImpl() {
content::RenderViewHost* const view_host = render_view_host();
std::string operation;

Powered by Google App Engine
This is Rietveld 408576698