Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/indexed_db/indexed_db_index_writer.cc

Issue 18023022: Blob support for IDB [Chromium] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Handle the rest of Josh's feedback. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/indexed_db/indexed_db_factory.cc ('K') | « content/browser/indexed_db/indexed_db_fake_backing_store.cc ('k') | content/browser/indexed_db/indexed_db_leveldb_coding.h » ('j') | content/browser/indexed_db/indexed_db_leveldb_coding.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/indexed_db/indexed_db_index_writer.cc
diff --git a/content/browser/indexed_db/indexed_db_index_writer.cc b/content/browser/indexed_db/indexed_db_index_writer.cc
index 3b36cad0ec9355a71580774d354614d356f3674d..c28b54a03e3598786b3d93b3e7a239865a82575f 100644
--- a/content/browser/indexed_db/indexed_db_index_writer.cc
+++ b/content/browser/indexed_db/indexed_db_index_writer.cc
@@ -112,7 +112,7 @@ bool IndexWriter::AddingKeyAllowed(
return true;
}
-bool MakeIndexWriters(
+bool MakeIndexWriters( // TODO(ericu): This should be a raw pointer?
jsbell 2013/12/20 00:44:20 Which, specifically?
ericu 2014/02/20 00:50:29 The transaction. I see nothing here that requires
jsbell 2014/02/20 22:55:50 Agreed.
scoped_refptr<IndexedDBTransaction> transaction,
IndexedDBBackingStore* backing_store,
int64 database_id,
« content/browser/indexed_db/indexed_db_factory.cc ('K') | « content/browser/indexed_db/indexed_db_fake_backing_store.cc ('k') | content/browser/indexed_db/indexed_db_leveldb_coding.h » ('j') | content/browser/indexed_db/indexed_db_leveldb_coding.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698