Blob support for IDB [Chromium]

content/browser/indexed_db/indexed_db_index_writer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_index_writer.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
 #include "content/browser/indexed_db/indexed_db_tracing.h"
@@ skipping 94 matching lines @@
                                             &found_primary_key,
                                             &found);
   if (!ok)
     return false;
   if (!found ||
       (primary_key.IsValid() && found_primary_key->IsEqual(primary_key)))
     *allowed = true;
   return true;
 }
 
-bool MakeIndexWriters(
+bool MakeIndexWriters(  // TODO(ericu): This should be a raw pointer?

[jsbell, 2013/12/20 00:44:20]

Which, specifically?

[ericu, 2014/02/20 00:50:29]

The transaction.  I see nothing here that requires refcount.

[jsbell, 2014/02/20 22:55:50]

Agreed. 

     scoped_refptr<IndexedDBTransaction> transaction,
     IndexedDBBackingStore* backing_store,
     int64 database_id,
     const IndexedDBObjectStoreMetadata& object_store,
     const IndexedDBKey& primary_key,  // makes a copy
     bool key_was_generated,
     const std::vector<int64>& index_ids,
     const std::vector<IndexedDBDatabase::IndexKeys>& index_keys,
     ScopedVector<IndexWriter>* index_writers,
     string16* error_message,
@@ skipping 34 matching lines @@
       return true;
 
     index_writers->push_back(index_writer.release());
   }
 
   *completed = true;
   return true;
 }
 
 }  // namespace content