Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1802263002: Add three UseCounters for LABEL element. (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Add three UseCounters for LABEL element. HTMLLabelElementFormIsDifferentFromControlForm: HTMLLabelElementHasNoControlAndFormIsAncestor: They are for label[form] deprecation. https://github.com/whatwg/html/issues/787 HTMLLabelElementControlForNonFormAssociatedElement This is for a LABEL with PROGRESS or METER. This is counted on any LABEL-specific behaviors. e.g. |form| IDL access, |control| IDL access, Clicking a LABEL, etc. This CL has no user-visible behavior changes. BUG=594447 TBR=isherman@chromium.org Review URL: https://codereview.chromium.org/1790143004 Cr-Commit-Position: refs/heads/master@{#380933} (cherry picked from commit 39e402647a842f4fcc12faded11d486aca8eda47) Committed: https://chromium.googlesource.com/chromium/src/+/e1c470bb537ac2c1fe83e8c1f6b3719782033ed9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.cpp View 3 chunks +24 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years, 9 months ago (2016-03-15 07:58:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1c470bb537ac2c1fe83e8c1f6b3719782033ed9.

Powered by Google App Engine
This is Rietveld 408576698