Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1790143004: Add three UseCounters for LABEL element. (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
keishi, Ilya Sherman
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add three UseCounters for LABEL element. HTMLLabelElementFormIsDifferentFromControlForm: HTMLLabelElementHasNoControlAndFormIsAncestor: They are for label[form] deprecation. https://github.com/whatwg/html/issues/787 HTMLLabelElementControlForNonFormAssociatedElement This is for a LABEL with PROGRESS or METER. This is counted on any LABEL-specific behaviors. e.g. |form| IDL access, |control| IDL access, Clicking a LABEL, etc. This CL has no user-visible behavior changes. BUG=594447 TBR=isherman@chromium.org Committed: https://crrev.com/39e402647a842f4fcc12faded11d486aca8eda47 Cr-Commit-Position: refs/heads/master@{#380933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.cpp View 3 chunks +24 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
tkent
Keishi, would you review this please?
4 years, 9 months ago (2016-03-14 04:22:14 UTC) #2
keishi
LGTM
4 years, 9 months ago (2016-03-14 04:37:21 UTC) #3
tkent
TBRing isherman@chromium.org. The histograms.xml change was done by a tool.
4 years, 9 months ago (2016-03-14 05:20:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1790143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1790143004/1
4 years, 9 months ago (2016-03-14 05:21:18 UTC) #8
Ilya Sherman
histograms.xml lgtm
4 years, 9 months ago (2016-03-14 05:38:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 06:06:57 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 06:09:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39e402647a842f4fcc12faded11d486aca8eda47
Cr-Commit-Position: refs/heads/master@{#380933}

Powered by Google App Engine
This is Rietveld 408576698