Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

Issue 1802123002: Unify Resource loading status tracking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
index 236650a15ea211a2162aad68ab1ae2ab26156ccd..566f6f1be12843d4e2ced8c8c5dc45f0a62ea211 100644
--- a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
@@ -173,7 +173,7 @@ TEST(ImageResourceTest, CancelOnDetach)
TEST(ImageResourceTest, DecodedDataRemainsWhileHasClients)
{
RefPtrWillBeRawPtr<ImageResource> cachedImage = ImageResource::create(ResourceRequest(), nullptr);
- cachedImage->setLoading(true);
+ cachedImage->setStatus(Resource::Pending);
MockImageResourceClient client(cachedImage);
@@ -206,7 +206,7 @@ TEST(ImageResourceTest, DecodedDataRemainsWhileHasClients)
TEST(ImageResourceTest, UpdateBitmapImages)
{
RefPtrWillBeRawPtr<ImageResource> cachedImage = ImageResource::create(ResourceRequest(), nullptr);
- cachedImage->setLoading(true);
+ cachedImage->setStatus(Resource::Pending);
MockImageResourceClient client(cachedImage);
@@ -228,7 +228,7 @@ TEST(ImageResourceTest, ReloadIfLoFi)
KURL testURL(ParsedURLString, "http://www.test.com/cancelTest.html");
URLTestHelpers::registerMockedURLLoad(testURL, "cancelTest.html", "text/html");
RefPtrWillBeRawPtr<ImageResource> cachedImage = ImageResource::create(ResourceRequest(testURL), nullptr);
- cachedImage->setLoading(true);
+ cachedImage->setStatus(Resource::Pending);
MockImageResourceClient client(cachedImage);
ResourceFetcher* fetcher = ResourceFetcher::create(nullptr);

Powered by Google App Engine
This is Rietveld 408576698