Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResource.cpp

Issue 1802123002: Unify Resource loading status tracking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ImageResource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.cpp b/third_party/WebKit/Source/core/fetch/ImageResource.cpp
index 8e2c9bd2964f75c130dd2e0565b70a89f7861510..134435f10156634c18d3600aab721fddac5124ec 100644
--- a/third_party/WebKit/Source/core/fetch/ImageResource.cpp
+++ b/third_party/WebKit/Source/core/fetch/ImageResource.cpp
@@ -52,9 +52,6 @@ PassRefPtrWillBeRawPtr<ImageResource> ImageResource::fetch(FetchRequest& request
return nullptr;
}
- if (fetcher->clientDefersImage(request.resourceRequest().url()))
- request.setDefer(FetchRequest::DeferredByClient);
-
return toImageResource(fetcher->requestResource(request, ImageResourceFactory()));
}
@@ -65,7 +62,6 @@ ImageResource::ImageResource(const ResourceRequest& resourceRequest)
, m_hasDevicePixelRatioHeaderValue(false)
{
WTF_LOG(Timers, "new ImageResource(ResourceRequest) %p", this);
- setStatus(Unknown);
setCustomAcceptHeader();
}
@@ -77,7 +73,6 @@ ImageResource::ImageResource(blink::Image* image)
{
WTF_LOG(Timers, "new ImageResource(Image) %p", this);
setStatus(Cached);
- setLoading(false);
setCustomAcceptHeader();
}
@@ -87,7 +82,6 @@ ImageResource::ImageResource(const ResourceRequest& resourceRequest, blink::Imag
{
WTF_LOG(Timers, "new ImageResource(ResourceRequest, Image) %p", this);
setStatus(Cached);
- setLoading(false);
setCustomAcceptHeader();
}
@@ -105,14 +99,6 @@ DEFINE_TRACE(ImageResource)
MultipartImageResourceParser::Client::trace(visitor);
}
-void ImageResource::load(ResourceFetcher* fetcher, const ResourceLoaderOptions& options)
-{
- if (!fetcher || fetcher->autoLoadImages())
- Resource::load(fetcher, options);
- else
- setLoading(false);
-}
-
void ImageResource::didAddClient(ResourceClient* c)
{
if (m_data && !m_image && !errorOccurred()) {
@@ -482,7 +468,8 @@ void ImageResource::onePartInMultipartReceived(const ResourceResponse& response)
if (m_multipartParsingState == MultipartParsingState::ParsingFirstPart) {
m_multipartParsingState = MultipartParsingState::FinishedParsingFirstPart;
// Notify finished when the first part ends.
- setLoading(false);
+ if (!errorOccurred())
+ setStatus(Cached);
checkNotify();
if (m_loader)
m_loader->didFinishLoadingOnePart(0, WebURLLoaderClient::kUnknownEncodedDataLength);

Powered by Google App Engine
This is Rietveld 408576698