Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1802003002: DO NOT SUBMIT SchedulerLock - DCHECK Checks (Closed)

Created:
4 years, 9 months ago by robliao
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@schedulerlock
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT SUBMIT SchedulerLock - DCHECK Checks Patch Set 1 shows the delta with https://codereview.chromium.org/1706123002/ Patch Set 2 inlines the code. This verifies that EXPECT_DCHECK_DEATH actually works. BUG=553459

Patch Set 1 : Delta with https://codereview.chromium.org/1706123002/ #

Patch Set 2 : All inlined. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+571 lines, -0 lines) Patch
M base/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
M base/base.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
A base/task_scheduler/scheduler_lock.h View 1 1 chunk +87 lines, -0 lines 0 comments Download
A base/task_scheduler/scheduler_lock_impl.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A base/task_scheduler/scheduler_lock_impl.cc View 1 1 chunk +132 lines, -0 lines 0 comments Download
A base/task_scheduler/scheduler_lock_unittest.cc View 1 1 chunk +299 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802003002/20001
4 years, 9 months ago (2016-03-14 20:22:03 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/80329)
4 years, 9 months ago (2016-03-14 20:35:11 UTC) #6
gab
4 years, 9 months ago (2016-03-15 01:17:24 UTC) #8
Message was sent while issue was closed. 
On 2016/03/14 20:35:11, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

Awesome, lots of red, thanks for increasing my confidence in the CQ/try bots :-)
(it used to be so much worse I prefer not to assume anything anymore..!)

Powered by Google App Engine
This is Rietveld 408576698