Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(202)

Issue 1801913002: Enable C++11 for Android builds. It is now required by bits of the Breakpad code. (Closed)

Created:
3 years, 10 months ago by plinehan
Modified:
3 years, 9 months ago
Reviewers:
vapier
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable C++11 for Android builds. It is now required by bits of the Breakpad code. Also, add the -D__STDC_LIMIT_MACROS definition to fix the ARM builds on Android. Without this, UINTPTR_MAX is not defined properly. It should, apparently, not be necessary to add this definition when C++11 is enabled, but is a known issue for certain versions of GCC/libc.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M android/sample_app/jni/Application.mk View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
plinehan
3 years, 10 months ago (2016-03-14 18:52:59 UTC) #2
vapier
if no one else has an opinion, lgtm
3 years, 10 months ago (2016-03-15 05:49:25 UTC) #3
plinehan
On 2016/03/15 05:49:25, vapier wrote: > if no one else has an opinion, lgtm Just ...
3 years, 10 months ago (2016-03-21 16:52:44 UTC) #4
vapier
3 years, 9 months ago (2016-04-05 01:36:31 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698