Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1801553004: Fix missing VisualElementsManifest.xml (Closed)

Created:
4 years, 9 months ago by scottmg
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Fix missing VisualElementsManifest.xml Move out of metro_driver too, as it doesn't have anything to do with Metro in its current incarnation. TBR=brettw@chromium.org R=gab@chromium.org, grt@chromium.org, dpranke@chromium.org BUG=593411 Review URL: https://codereview.chromium.org/1790723002 Cr-Commit-Position: refs/heads/master@{#380886} (cherry picked from commit 170c14bac8a2dc89c34907545116fb0a64e4f351) Committed: https://chromium.googlesource.com/chromium/src/+/4182a36f472e4db7d6e52fb999ff6500de079bba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -36 lines) Patch
M chrome/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/mini_installer/config/chrome_canary_installed.prop View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/mini_installer/config/chrome_system_installed.prop View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/mini_installer/config/chrome_user_installed.prop View 1 chunk +1 line, -0 lines 0 comments Download
M win8/BUILD.gn View 1 chunk +13 lines, -0 lines 0 comments Download
M win8/metro_driver/BUILD.gn View 2 chunks +0 lines, -16 lines 0 comments Download
M win8/metro_driver/metro_driver.gyp View 1 chunk +0 lines, -12 lines 0 comments Download
D win8/metro_driver/resources/Logo.png View Binary file 0 comments Download
D win8/metro_driver/resources/SecondaryTile.png View Binary file 0 comments Download
D win8/metro_driver/resources/SmallLogo.png View Binary file 0 comments Download
D win8/metro_driver/resources/chrome.VisualElementsManifest.xml View 1 chunk +0 lines, -9 lines 0 comments Download
A + win8/resources/Logo.png View Binary file 0 comments Download
A + win8/resources/SecondaryTile.png View Binary file 0 comments Download
A + win8/resources/SmallLogo.png View Binary file 0 comments Download
A + win8/resources/chrome.VisualElementsManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
M win8/win8.gyp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
scottmg
Committed patchset #1 (id:1) manually as 4182a36f472e4db7d6e52fb999ff6500de079bba.
4 years, 9 months ago (2016-03-14 16:45:28 UTC) #2
Dirk Pranke
4 years, 9 months ago (2016-03-14 20:17:53 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698