Fix missing VisualElementsManifest.xml

Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with
Metro in its current incarnation.

TBR=brettw@chromium.org
R=gab@chromium.org, grt@chromium.org, dpranke@chromium.org
BUG=593411
Committed: https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351
Cr-Commit-Position: refs/heads/master@{#380886}

[scottmg, 2016-03-11 22:23:47]

Description was changed from

==========
Fix missing VisualElementsManifest.xml

R=gab@chromium.org, grt@chromium.org
BUG=593411
==========

to

==========
Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with Metro in
its current incarnation.

R=gab@chromium.org, grt@chromium.org
BUG=593411
==========

[scottmg, 2016-03-11 22:30:09]

Anyone confident (or not) about whether we need SecondaryTile.png any more? It
seems unused-ish.

[scottmg, 2016-03-11 22:30:26]

Description was changed from

==========
Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with Metro in
its current incarnation.

R=gab@chromium.org, grt@chromium.org
BUG=593411
==========

to

==========
Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with
Metro in its current incarnation.

R=gab@chromium.org, grt@chromium.org
BUG=593411
==========

[scottmg, 2016-03-12 00:36:51]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-12 00:37:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1790723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1790723002/1

[commit-bot: I haz the power, 2016-03-12 01:37:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-12 01:37:52]

Dry run: This issue passed the CQ dry run.

[grt (UTC plus 2), 2016-03-12 14:18:52]

On 2016/03/11 22:30:09, scottmg wrote:
> Anyone confident (or not) about whether we need SecondaryTile.png any more? It
> seems unused-ish.

The only thing I can find related to the secondary tile is
MetroPinToStartScreen. Is that now dead code? Note: I'm using codesearch at the
moment, so most win-specific code is invisible to me.

[grt (UTC plus 2), 2016-03-12 14:19:32]

w00t for passing tests. one of these days we should probably get rid of the win8
directory, but that can wait for another day. lgtm.

[scottmg, 2016-03-12 23:22:18]

On 2016/03/12 14:18:52, grt (very slow) wrote:
> On 2016/03/11 22:30:09, scottmg wrote:
> > Anyone confident (or not) about whether we need SecondaryTile.png any more?
It
> > seems unused-ish.
> 
> The only thing I can find related to the secondary tile is
> MetroPinToStartScreen. Is that now dead code? Note: I'm using codesearch at
the
> moment, so most win-specific code is invisible to me.

OK, that's all I found too. I'm going to leave it in this CL since this one has
to be merged (just in case), and I'll remove it separately afterwards then.

Thanks

[scottmg, 2016-03-12 23:25:14]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-03-12 23:25:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1790723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1790723002/1

[commit-bot: I haz the power, 2016-03-12 23:38:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-12 23:38:21]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scottmg, 2016-03-12 23:39:22]

Description was changed from

==========
Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with
Metro in its current incarnation.

R=gab@chromium.org, grt@chromium.org
BUG=593411
==========

to

==========
Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with
Metro in its current incarnation.

TBR=dpranke@chromium.org
R=gab@chromium.org, grt@chromium.org
BUG=593411
==========

[scottmg, 2016-03-12 23:39:52]

scottmg@chromium.org changed reviewers:
+ dpranke@chromium.org

[scottmg, 2016-03-12 23:39:53]

tbr +dpranke for chrome/BUILD.gn

[scottmg, 2016-03-12 23:40:01]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-03-12 23:40:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1790723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1790723002/1

[Dirk Pranke, 2016-03-12 23:53:57]

I'm not an owner for //chrome/BUILD.gn, but LGTM .

[Dirk Pranke, 2016-03-12 23:54:19]

Description was changed from

==========
Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with
Metro in its current incarnation.

TBR=dpranke@chromium.org
R=gab@chromium.org, grt@chromium.org
BUG=593411
==========

to

==========
Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with
Metro in its current incarnation.

TBR=brettw@chromium.org
R=gab@chromium.org, grt@chromium.org, dpranke@chromium.org
BUG=593411
==========

[scottmg, 2016-03-12 23:57:02]

On 2016/03/12 23:53:57, Dirk Pranke wrote:
> I'm not an owner for //chrome/BUILD.gn, but LGTM .

Oh, you're just per-file on the root, oops.

(We probably should make BUILD.gn * like *.gypi are? dunno)

[commit-bot: I haz the power, 2016-03-13 00:15:29]

Description was changed from

==========
Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with
Metro in its current incarnation.

TBR=brettw@chromium.org
R=gab@chromium.org, grt@chromium.org, dpranke@chromium.org
BUG=593411
==========

to

==========
Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with
Metro in its current incarnation.

TBR=brettw@chromium.org
R=gab@chromium.org, grt@chromium.org, dpranke@chromium.org
BUG=593411
==========

[commit-bot: I haz the power, 2016-03-13 00:15:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-13 00:16:17]

Description was changed from

==========
Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with
Metro in its current incarnation.

TBR=brettw@chromium.org
R=gab@chromium.org, grt@chromium.org, dpranke@chromium.org
BUG=593411
==========

to

==========
Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with
Metro in its current incarnation.

TBR=brettw@chromium.org
R=gab@chromium.org, grt@chromium.org, dpranke@chromium.org
BUG=593411

Committed: https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351
Cr-Commit-Position: refs/heads/master@{#380886}
==========

[commit-bot: I haz the power, 2016-03-13 00:16:18]

Patchset 1 (id:??) landed as
https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351
Cr-Commit-Position: refs/heads/master@{#380886}

[Dirk Pranke, 2016-03-13 02:58:18]

On Sat, Mar 12, 2016 at 3:57 PM, <scottmg@chromium.org> wrote:

> (We probably should make BUILD.gn * like *.gypi are? dunno)
>

I'm not sure what you mean by this. *.gypi where? No per-file rules
recurse, although they should (crbug.com/235756).

>
> https://codereview.chromium.org/1790723002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2016-03-14 16:35:37]

On 2016/03/13 02:58:18, Dirk Pranke wrote:
> On Sat, Mar 12, 2016 at 3:57 PM, <mailto:scottmg@chromium.org> wrote:
> 
> > (We probably should make BUILD.gn * like *.gypi are? dunno)
> >
> 
> I'm not sure what you mean by this. *.gypi where? No per-file rules
> recurse, although they should (crbug.com/235756).

I meant that in chrome/OWNERS we have

per-file *.gypi=*

so that this sort of simple add/remove files doesn't require an owner review. It
would seem reasonable to make a similar exception for BUILD.gn.

> 
> >
> > https://codereview.chromium.org/1790723002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[gab, 2016-03-14 18:12:23]

lgtm

On 2016/03/12 23:22:18, scottmg wrote:
> On 2016/03/12 14:18:52, grt (very slow) wrote:
> > On 2016/03/11 22:30:09, scottmg wrote:
> > > Anyone confident (or not) about whether we need SecondaryTile.png any
more?
> It
> > > seems unused-ish.
> > 
> > The only thing I can find related to the secondary tile is
> > MetroPinToStartScreen. Is that now dead code? Note: I'm using codesearch at
> the
> > moment, so most win-specific code is invisible to me.
> 
> OK, that's all I found too. I'm going to leave it in this CL since this one
has
> to be merged (just in case), and I'll remove it separately afterwards then.

Looking at chrome.release it's actually not even listed in right place anymore
(so even more likely unused)... It should be dropped in Visual Elements but
isn't (and there is a comment on the VisualElements that says it expects 3 files
yet there are only 2 below it -- pretty sure the third one is the unused
SecondaryTile.png).