Handle direction control in compositor Animations

webkit/renderer/compositor_bindings/web_animation_impl.cc

Index: webkit/renderer/compositor_bindings/web_animation_impl.cc
diff --git a/webkit/renderer/compositor_bindings/web_animation_impl.cc b/webkit/renderer/compositor_bindings/web_animation_impl.cc
index c401d5c974128060ca7a6f59530fa726ff1dd463..a56e129cd0285922a6ba930ba4bdafbd2631c23b 100644
--- a/webkit/renderer/compositor_bindings/web_animation_impl.cc
+++ b/webkit/renderer/compositor_bindings/web_animation_impl.cc
@@ -95,13 +95,24 @@ void WebAnimationImpl::setTimeOffset(double monotonic_time) {
   animation_->set_time_offset(monotonic_time);
 }
 
+#if WEB_ANIMATION_SUPPORTS_FULL_DIRECTION
+blink::WebAnimation::Direction WebAnimationImpl::direction() const {
+  return static_cast<WebAnimationImpl::Direction>(animation_->direction());
+}
+
+void WebAnimationImpl::setDirection(Direction direction) {
+  return animation_->set_direction(
+      static_cast<cc::Animation::Direction>(direction));

[ajuma, 2014/02/28 17:55:51]

I know we have existing code that assumes that enums in cc and in Blink happen
to have the same values, but we should probably avoid adding more such
dependencies for new enums. Instead, we can just use a switch here and
explicitly convert from the Blink enum to the cc enum.

+}
+#else
 bool WebAnimationImpl::alternatesDirection() const {
-  return animation_->alternates_direction();
+  return animation_->direction() == cc::Animation::Alternate;
 }
 
 void WebAnimationImpl::setAlternatesDirection(bool alternates) {
-  animation_->set_alternates_direction(alternates);
+  return animation_->set_direction(cc::Animation::Alternate);
 }
+#endif
 
 scoped_ptr<cc::Animation> WebAnimationImpl::PassAnimation() {
   animation_->set_needs_synchronized_start_time(true);