Handle direction control in compositor Animations

webkit/renderer/compositor_bindings/web_animation_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/renderer/compositor_bindings/web_animation_impl.h"
 
 #include "cc/animation/animation.h"
 #include "cc/animation/animation_curve.h"
 #include "cc/animation/animation_id_provider.h"
 #include "third_party/WebKit/public/platform/WebAnimation.h"
@@ skipping 77 matching lines @@
 }
 
 double WebAnimationImpl::timeOffset() const {
   return animation_->time_offset();
 }
 
 void WebAnimationImpl::setTimeOffset(double monotonic_time) {
   animation_->set_time_offset(monotonic_time);
 }
 
+#if WEB_ANIMATION_SUPPORTS_FULL_DIRECTION
+blink::WebAnimation::Direction WebAnimationImpl::direction() const {
+  return static_cast<WebAnimationImpl::Direction>(animation_->direction());
+}
+
+void WebAnimationImpl::setDirection(Direction direction) {
+  return animation_->set_direction(
+      static_cast<cc::Animation::Direction>(direction));

[ajuma, 2014/02/28 17:55:51]

I know we have existing code that assumes that enums in cc and in Blink happen
to have the same values, but we should probably avoid adding more such
dependencies for new enums. Instead, we can just use a switch here and
explicitly convert from the Blink enum to the cc enum.

+}
+#else
 bool WebAnimationImpl::alternatesDirection() const {
-  return animation_->alternates_direction();
+  return animation_->direction() == cc::Animation::Alternate;
 }
 
 void WebAnimationImpl::setAlternatesDirection(bool alternates) {
-  animation_->set_alternates_direction(alternates);
+  return animation_->set_direction(cc::Animation::Alternate);
 }
+#endif
 
 scoped_ptr<cc::Animation> WebAnimationImpl::PassAnimation() {
   animation_->set_needs_synchronized_start_time(true);
   return animation_.Pass();
 }
 
 #define COMPILE_ASSERT_MATCHING_ENUMS(webkit_name, cc_name)                    \
     COMPILE_ASSERT(static_cast<int>(webkit_name) == static_cast<int>(cc_name), \
                    mismatching_enums)
 
 COMPILE_ASSERT_MATCHING_ENUMS(
     WebAnimation::TargetPropertyTransform, Animation::Transform);
 COMPILE_ASSERT_MATCHING_ENUMS(
     WebAnimation::TargetPropertyOpacity, Animation::Opacity);
 COMPILE_ASSERT_MATCHING_ENUMS(
     WebAnimation::TargetPropertyFilter, Animation::Filter);
 #if WEB_SCROLL_OFFSET_ANIMATION_CURVE_IS_DEFINED
 COMPILE_ASSERT_MATCHING_ENUMS(
     WebAnimation::TargetPropertyScrollOffset, Animation::ScrollOffset);
 #endif
 
 }  // namespace webkit