Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1801493003: Fix ppb_graphics_3d such that the thunk can be generated again (Closed)

Created:
4 years, 9 months ago by raymes
Modified:
4 years, 9 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ppb_graphics_3d such that the thunk can be generated again https://codereview.chromium.org/1586883002 introduced a change which made the thunk for this API not generatable. This CL fixes that by moving the non-mechanical bits into the implementation. BUG=593205 Committed: https://crrev.com/bc71ad0b1e8f26cb555e3e127906bdbc57ef0816 Cr-Commit-Position: refs/heads/master@{#380944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppb_graphics_3d_shared.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/shared_impl/ppb_graphics_3d_shared.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_api.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_thunk.cc View 2 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
raymes
4 years, 9 months ago (2016-03-14 06:18:29 UTC) #2
Sam McNally
lgtm
4 years, 9 months ago (2016-03-14 06:36:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801493003/1
4 years, 9 months ago (2016-03-14 06:38:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 07:30:46 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 07:31:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc71ad0b1e8f26cb555e3e127906bdbc57ef0816
Cr-Commit-Position: refs/heads/master@{#380944}

Powered by Google App Engine
This is Rietveld 408576698