Converted Ppapi post swap buffer sync point to use sync tokens.

Converted Ppapi post swap buffer sync point to use sync tokens.

This CL removes the sync point inserted directly from the command
buffer after swap buffers and just uses GL to insert a fence sync
after each swap buffer instead.

BUG=514815
Committed: https://crrev.com/ddfdbbbf08df6ab8f1ca5f81330eed3e5100bc9c
Cr-Commit-Position: refs/heads/master@{#369575}

[David Yen, 2016-01-14 00:07:11]

dyen@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2016-01-14 00:21:36]

LGTM!

https://codereview.chromium.org/1586883002/diff/1/content/renderer/pepper/ppb...
File content/renderer/pepper/ppb_graphics_3d_impl.cc (right):

https://codereview.chromium.org/1586883002/diff/1/content/renderer/pepper/ppb...
content/renderer/pepper/ppb_graphics_3d_impl.cc:188:
gl->OrderingBarrierCHROMIUM();
nit: maybe DCHECK(!sync_token.HasData()) in this case.
FYI this code is for in-process plugins, which is only exercised by test code
(if at all any more, actually).

https://codereview.chromium.org/1586883002/diff/1/ppapi/proxy/ppb_graphics_3d...
File ppapi/proxy/ppb_graphics_3d_proxy.cc (right):

https://codereview.chromium.org/1586883002/diff/1/ppapi/proxy/ppb_graphics_3d...
ppapi/proxy/ppb_graphics_3d_proxy.cc:130: int32_t
Graphics3D::DoSwapBuffers(const gpu::SyncToken& sync_token) {
nit: maybe DCHECK(!sync_token.HasData());

[David Yen, 2016-01-14 00:36:38]

Added DCHECKs and a brief comment

https://codereview.chromium.org/1586883002/diff/1/content/renderer/pepper/ppb...
File content/renderer/pepper/ppb_graphics_3d_impl.cc (right):

https://codereview.chromium.org/1586883002/diff/1/content/renderer/pepper/ppb...
content/renderer/pepper/ppb_graphics_3d_impl.cc:188:
gl->OrderingBarrierCHROMIUM();
On 2016/01/14 00:21:36, piman (Slow to review) wrote:
> nit: maybe DCHECK(!sync_token.HasData()) in this case.
> FYI this code is for in-process plugins, which is only exercised by test code
> (if at all any more, actually).

Done.

https://codereview.chromium.org/1586883002/diff/1/ppapi/proxy/ppb_graphics_3d...
File ppapi/proxy/ppb_graphics_3d_proxy.cc (right):

https://codereview.chromium.org/1586883002/diff/1/ppapi/proxy/ppb_graphics_3d...
ppapi/proxy/ppb_graphics_3d_proxy.cc:130: int32_t
Graphics3D::DoSwapBuffers(const gpu::SyncToken& sync_token) {
On 2016/01/14 00:21:36, piman (Slow to review) wrote:
> nit: maybe DCHECK(!sync_token.HasData());

Done.

[David Yen, 2016-01-14 00:37:35]

dyen@chromium.org changed reviewers:
+ bbudge@chromium.org, dcheng@chromium.org

[David Yen, 2016-01-14 00:37:35]

Adding more owner reviewers

+dcheng@ for ppapi_messages.h review.

+bbudge@ for all the ppapi changes.

[David Yen, 2016-01-14 01:10:28]

Description was changed from

==========
Converted Ppapi post swap buffer sync point to use sync tokens.

This CL removes the sync point inserted directly from the command
buffer after swap buffers and just uses GL to insert a fence sync
after each swap buffer instead.

BUG=514815
==========

to

==========
Converted Ppapi post swap buffer sync point to use sync tokens.

This CL removes the sync point inserted directly from the command
buffer after swap buffers and just uses GL to insert a fence sync
after each swap buffer instead.

BUG=514815
==========

[David Yen, 2016-01-14 01:10:28]

dyen@chromium.org changed reviewers:
- bbudge@chromium.org

[David Yen, 2016-01-14 01:11:57]

dyen@chromium.org changed reviewers:
+ bbudge@chromium.org

[dcheng, 2016-01-14 02:33:33]

ipc changes lgtm

https://codereview.chromium.org/1586883002/diff/20001/content/renderer/pepper...
File content/renderer/pepper/pepper_plugin_instance_impl.cc (right):

https://codereview.chromium.org/1586883002/diff/20001/content/renderer/pepper...
content/renderer/pepper/pepper_plugin_instance_impl.cc:787: if
(!texture_layer_.get()) {
Nit: remove the .get(), since this is being updated anyway

[David Yen, 2016-01-14 19:14:36]

bbudge@ is out until 1-18 but I'll just wait for him to be back since AFAIK
there are no other real ppapi people anymore.

https://codereview.chromium.org/1586883002/diff/20001/content/renderer/pepper...
File content/renderer/pepper/pepper_plugin_instance_impl.cc (right):

https://codereview.chromium.org/1586883002/diff/20001/content/renderer/pepper...
content/renderer/pepper/pepper_plugin_instance_impl.cc:787: if
(!texture_layer_.get()) {
On 2016/01/14 02:33:33, dcheng wrote:
> Nit: remove the .get(), since this is being updated anyway

Done. I removed all of them for texture_layer_.get() when used as a boolean.

[piman, 2016-01-14 19:30:17]

piman@chromium.org changed reviewers:
+ raymes@chromium.org

[piman, 2016-01-14 19:30:17]

+raymes: can you take a look? (I already reviewed)

[raymes, 2016-01-14 21:58:52]

lgtm

[David Yen, 2016-01-14 22:12:55]

The CQ bit was checked by dyen@chromium.org

[David Yen, 2016-01-14 22:12:55]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1586883002/#ps40001
(title: "Removed some .get() booleans")

[commit-bot: I haz the power, 2016-01-14 22:15:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586883002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586883002/40001

[commit-bot: I haz the power, 2016-01-14 22:21:45]

Description was changed from

==========
Converted Ppapi post swap buffer sync point to use sync tokens.

This CL removes the sync point inserted directly from the command
buffer after swap buffers and just uses GL to insert a fence sync
after each swap buffer instead.

BUG=514815
==========

to

==========
Converted Ppapi post swap buffer sync point to use sync tokens.

This CL removes the sync point inserted directly from the command
buffer after swap buffers and just uses GL to insert a fence sync
after each swap buffer instead.

BUG=514815
==========

[commit-bot: I haz the power, 2016-01-14 22:21:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-14 22:22:35]

Description was changed from

==========
Converted Ppapi post swap buffer sync point to use sync tokens.

This CL removes the sync point inserted directly from the command
buffer after swap buffers and just uses GL to insert a fence sync
after each swap buffer instead.

BUG=514815
==========

to

==========
Converted Ppapi post swap buffer sync point to use sync tokens.

This CL removes the sync point inserted directly from the command
buffer after swap buffers and just uses GL to insert a fence sync
after each swap buffer instead.

BUG=514815

Committed: https://crrev.com/ddfdbbbf08df6ab8f1ca5f81330eed3e5100bc9c
Cr-Commit-Position: refs/heads/master@{#369575}
==========

[commit-bot: I haz the power, 2016-01-14 22:22:36]

Patchset 3 (id:??) landed as
https://crrev.com/ddfdbbbf08df6ab8f1ca5f81330eed3e5100bc9c
Cr-Commit-Position: refs/heads/master@{#369575}